[GitHub] [directory-scimple] bdemers commented on a diff in pull request #251: patch fixes and test cases

["bdemers (via GitHub)" <gi...@apache.org>]

bdemers commented on code in PR #251:
URL: https://github.com/apache/directory-scimple/pull/251#discussion_r1098042150


##########
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchHandlerImpl.java:
##########
@@ -279,11 +300,14 @@ public <T extends ScimResource> void applyMultiValue(T source, Map<String, Objec
           throw new UnsupportedFilterException("Attribute cannot be added, only comparison expressions are supported when the existing item does not exist.");
         }
         AttributeComparisonExpression comparisonExpression = (AttributeComparisonExpression) valuePathExpression.getAttributeExpression();
+        checkPrimary(subAttributeName, items, value);
 
-      items.add(Map.of(
+        items.add(new HashMap<>(Map.of(

Review Comment:
   Does this need to be a HashMap?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org