You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xumanbu (via GitHub)" <gi...@apache.org> on 2024/07/02 17:03:01 UTC
Re: [PR] [#1608] refactor: Reuse ShuffleManageClient in ShuffleReader and ShuffleWriter [incubator-uniffle]
xumanbu commented on code in PR #1838:
URL: https://github.com/apache/incubator-uniffle/pull/1838#discussion_r1657155752
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
It's your original idea, but I discovered it already initialized in the `RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a 'lazyShuffleManagerClient' instead of 'shuffleManagerClient'.
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
It's your original idea, but I discovered it already initialized in the `RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a 'lazyShuffleManagerClient' instead of 'shuffleManagerClient' initialized in new `RssShuffleManage` at now.
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
Agree with u. my original idea is same with u, but I discovered it already initialized in the `RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a `lazyShuffleManagerClient` instead of `shuffleManagerClient` initialized in new `RssShuffleManage` at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org