You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2016/02/28 12:07:07 UTC

[jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()

    [ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171008#comment-15171008 ] 

Uwe Schindler commented on LUCENE-7053:
---------------------------------------

There is a bit code duplication in both tests (sorting Strings in code point order), should we maybe move the new comparator to TestUtil?

> Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()
> -----------------------------------------------------------
>
>                 Key: LUCENE-7053
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7053
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7053.patch
>
>
> Followup from LUCENE-7052: This removes the legacy, deprecated getUTF8SortedAsUTF16Comparator() in the BytesRef class. The only left over user was TSTLookup. Moves the code there as private impl detail.
> This also converts the comparators to lambdas for better readability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org