[GitHub] [pulsar] merlimat commented on a change in pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl
URL: https://github.com/apache/pulsar/pull/4381#discussion_r288326755
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
 ##########
 @@ -46,33 +45,31 @@
     private transient ServiceUrlProvider serviceUrlProvider;
 
     @JsonIgnore
-    private transient Authentication authentication = new AuthenticationDisabled();
-    @JsonIgnore
-    private transient String authPluginClassName;
-    @JsonIgnore
-    private transient Map<String, String> authParams;
+    @Builder.Default private transient Authentication authentication = new AuthenticationDisabled();
+    private String authPluginClassName;
+    private String authParams;
 
-    private long operationTimeoutMs = 30000;
-    private long statsIntervalSeconds = 60;
+    @Builder.Default private long operationTimeoutMs = 30000;
 
 Review comment:
   All these annotations seem to go a bit against the spirit of Lombok :) which is there to reduce the boiler-plate code.
   
   Could we instead remove the `@Builder` and rely on the declared defaults (and just use `setX()` ) ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services