You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/11/25 06:05:51 UTC

Re: Review Request 15799: Catch-up Replicated Log 0: Added a version that recognizes both the old and the new log format.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15799/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 5:05 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.


Changes
-------

BenH's comments. Rebased with master. Changed the title.


Summary (updated)
-----------------

Catch-up Replicated Log 0: Added a version that recognizes both the old and the new log format.


Bugs: MESOS-736
    https://issues.apache.org/jira/browse/MESOS-736


Repository: mesos-git


Description
-------

See summary. This version can be rolled out first so that we can easily roll back if we want.

Once this version becomes stable, we can continue our upgrade with a following patch.


Diffs (updated)
-----

  src/log/replica.cpp 59a6ff3 
  src/messages/log.proto 3d5859f 

Diff: https://reviews.apache.org/r/15799/diff/


Testing
-------

make check

bin/mesos-tests.sh --gtest_filter=LogTest.*:ReplicaTest.*:CoordinatorTest.*:LogZooKeeperTest.* --gtest_repeat=100


Thanks,

Jie Yu


Re: Review Request 15799: Catch-up Replicated Log 0: Added a version that recognizes both the old and the new log format.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15799/#review29365
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 25, 2013, 5:05 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15799/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 5:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-736
>     https://issues.apache.org/jira/browse/MESOS-736
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. This version can be rolled out first so that we can easily roll back if we want.
> 
> Once this version becomes stable, we can continue our upgrade with a following patch.
> 
> 
> Diffs
> -----
> 
>   src/log/replica.cpp 59a6ff3 
>   src/messages/log.proto 3d5859f 
> 
> Diff: https://reviews.apache.org/r/15799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> bin/mesos-tests.sh --gtest_filter=LogTest.*:ReplicaTest.*:CoordinatorTest.*:LogZooKeeperTest.* --gtest_repeat=100
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 15799: Catch-up Replicated Log 0: Added a version that recognizes both the old and the new log format.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15799/#review29363
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On Nov. 25, 2013, 5:05 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15799/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 5:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-736
>     https://issues.apache.org/jira/browse/MESOS-736
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. This version can be rolled out first so that we can easily roll back if we want.
> 
> Once this version becomes stable, we can continue our upgrade with a following patch.
> 
> 
> Diffs
> -----
> 
>   src/log/replica.cpp 59a6ff3 
>   src/messages/log.proto 3d5859f 
> 
> Diff: https://reviews.apache.org/r/15799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> bin/mesos-tests.sh --gtest_filter=LogTest.*:ReplicaTest.*:CoordinatorTest.*:LogZooKeeperTest.* --gtest_repeat=100
> 
> 
> Thanks,
> 
> Jie Yu
> 
>