You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/03 08:15:27 UTC

[GitHub] [camel-quarkus] erayerdem opened a new pull request #3430: Update cron.adoc

erayerdem opened a new pull request #3430:
URL: https://github.com/apache/camel-quarkus/pull/3430


    from("cron:tab?schedule=0/1+*+*+*+*+?")
                   .setBody().constant("event")
                   .log("${body}");  
   
   cron job doesn't works with just cron component dependence .  we must add quarts component for cron component
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] erayerdem commented on pull request #3430: Update cron.adoc

Posted by GitBox <gi...@apache.org>.
erayerdem commented on pull request #3430:
URL: https://github.com/apache/camel-quarkus/pull/3430#issuecomment-1004018020


   @aldettinger , thanks for interested . u can write 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on pull request #3430: Update cron.adoc

Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3430:
URL: https://github.com/apache/camel-quarkus/pull/3430#issuecomment-1004014719


   @erayerdem Do you think the doc update is not needed anymore ? If you don't have time, let me know, I could try to write something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on pull request #3430: Update cron.adoc

Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3430:
URL: https://github.com/apache/camel-quarkus/pull/3430#issuecomment-1003978608


   Hello @erayerdem and many thanks for stepping in. From the [camel documentation](https://camel.apache.org/components/3.14.x/cron-component.html), the cron component is just a generic interface component. An implementation should be selected, I wonder if it is safe to assume that it will always be quartz ?
   
   Also, note that the doc files are generated. Given that, I wonder whether it would be a good idea to add the `src/main/doc` directly in the cron extension, for instance as it was done in the [xslt extension](https://github.com/apache/camel-quarkus/blob/main/extensions/xslt/runtime/src/main/doc/configuration.adoc). There we could have a doc describing that a cron implementation need to be chosen, for instance quartz ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] erayerdem closed pull request #3430: Update cron.adoc

Posted by GitBox <gi...@apache.org>.
erayerdem closed pull request #3430:
URL: https://github.com/apache/camel-quarkus/pull/3430


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org