You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/01 13:23:06 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #2919: [Refactor][Module Name] Refactor title
likyh opened a new issue, #2919:
URL: https://github.com/apache/incubator-devlake/issues/2919
## What and why to refactor
https://github.com/apache/incubator-devlake/blame/3b24e450ed2a56d905b6b66c11e520894d47ea10/config-ui/src/hooks/useJIRA.jsx#L67-L89
It will never catch an error in Line 85 even if the request fails.
await should catch error by `try/catch` instead of `Promise.catch` in Line 77.
So sometimes it will request fail but without any tips. Or maybe there are some other unpredictable bugs.
## Describe the solution you think
unwrap function `fetchIssueFields` and delete `Promise.catch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #2919: [Refactor][config-ui] await should catch error by try/catch instead of Promise.catch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #2919: [Refactor][config-ui] await should catch error by try/catch instead of Promise.catch
URL: https://github.com/apache/incubator-devlake/issues/2919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2919: [Refactor][config-ui] await should catch error by try/catch instead of Promise.catch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2919:
URL: https://github.com/apache/incubator-devlake/issues/2919#issuecomment-1264515567
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2919: [Refactor][config-ui] await should catch error by try/catch instead of Promise.catch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2919:
URL: https://github.com/apache/incubator-devlake/issues/2919#issuecomment-1272665068
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org