You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/23 08:56:11 UTC
Review Request 34627: Create/Edit widget: Wizard doesn't navigate to
the current wizard page when another window is open
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11359
https://issues.apache.org/jira/browse/AMBARI-11359
Repository: ambari
Description
-------
STR:
Navigate through the Create Widget Wizard.
Once it reach metrics and expression page close the browser window
Open another browser window
Expected behavior: This should directly navigate to metrics and expression page
Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
ambari-web/app/router.js 46e62aa
Diff: https://reviews.apache.org/r/34627/diff/
Testing
-------
Tested the patch to work on live cluster
verified that all unit tests passes successfully
Thanks,
Jaimin Jetly
Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate
to the current wizard page when another window is open
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/#review85093
-----------------------------------------------------------
- Yusaku Sako
On May 23, 2015, 6:56 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34627/
> -----------------------------------------------------------
>
> (Updated May 23, 2015, 6:56 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11359
> https://issues.apache.org/jira/browse/AMBARI-11359
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Navigate through the Create Widget Wizard.
> Once it reach metrics and expression page close the browser window
> Open another browser window
> Expected behavior: This should directly navigate to metrics and expression page
> Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
> ambari-web/app/router.js 46e62aa
>
> Diff: https://reviews.apache.org/r/34627/diff/
>
>
> Testing
> -------
>
> Tested the patch to work on live cluster
> verified that all unit tests passes successfully
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate
to the current wizard page when another window is open
Posted by Jaimin Jetly <ja...@hortonworks.com>.
> On May 24, 2015, 2:09 p.m., Yusaku Sako wrote:
> > ambari-web/app/router.js, line 374
> > <https://reviews.apache.org/r/34627/diff/1/?file=970855#file970855line374>
> >
> > A minor nit, but this is getting a little ugly.
> > Perhaps we can simplify this by checking for clusterStatusOnServer once at the top and then doing switch on clusterStatusOnServer.wizardControllerName, case on App.router.get('widgetWizardController.name'), or maybe even better would be to create an object with the mapping and make the routing generic. Like
> > {
> > ...,
> > 'rMHighAvailabilityWizardController': 'main.services.enableRMHighAvailability',
> > 'rollbackHighAvailabilityWizardController': 'main.services.rollbackHighAvailability',
> > ...
> > }
> > and route based on this.
> > Maybe create another JIRA to take care of this in the future.
The suggestion has been incorporated in the new patch
- Jaimin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/#review85092
-----------------------------------------------------------
On May 26, 2015, 9:10 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34627/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 9:10 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11359
> https://issues.apache.org/jira/browse/AMBARI-11359
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Navigate through the Create Widget Wizard.
> Once it reach metrics and expression page close the browser window
> Open another browser window
> Expected behavior: This should directly navigate to metrics and expression page
> Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
> ambari-web/app/data/controller_route.js PRE-CREATION
> ambari-web/app/router.js 46e62aa
>
> Diff: https://reviews.apache.org/r/34627/diff/
>
>
> Testing
> -------
>
> Tested the patch to work on live cluster
> verified that all unit tests passes successfully
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate
to the current wizard page when another window is open
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/#review85092
-----------------------------------------------------------
ambari-web/app/router.js
<https://reviews.apache.org/r/34627/#comment136567>
A minor nit, but this is getting a little ugly.
Perhaps we can simplify this by checking for clusterStatusOnServer once at the top and then doing switch on clusterStatusOnServer.wizardControllerName, case on App.router.get('widgetWizardController.name'), or maybe even better would be to create an object with the mapping and make the routing generic. Like
{
...,
'rMHighAvailabilityWizardController': 'main.services.enableRMHighAvailability',
'rollbackHighAvailabilityWizardController': 'main.services.rollbackHighAvailability',
...
}
and route based on this.
Maybe create another JIRA to take care of this in the future.
- Yusaku Sako
On May 23, 2015, 6:56 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34627/
> -----------------------------------------------------------
>
> (Updated May 23, 2015, 6:56 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11359
> https://issues.apache.org/jira/browse/AMBARI-11359
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Navigate through the Create Widget Wizard.
> Once it reach metrics and expression page close the browser window
> Open another browser window
> Expected behavior: This should directly navigate to metrics and expression page
> Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
> ambari-web/app/router.js 46e62aa
>
> Diff: https://reviews.apache.org/r/34627/diff/
>
>
> Testing
> -------
>
> Tested the patch to work on live cluster
> verified that all unit tests passes successfully
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate
to the current wizard page when another window is open
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/#review85260
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On May 26, 2015, 9:10 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34627/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 9:10 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11359
> https://issues.apache.org/jira/browse/AMBARI-11359
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Navigate through the Create Widget Wizard.
> Once it reach metrics and expression page close the browser window
> Open another browser window
> Expected behavior: This should directly navigate to metrics and expression page
> Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
> ambari-web/app/data/controller_route.js PRE-CREATION
> ambari-web/app/router.js 46e62aa
>
> Diff: https://reviews.apache.org/r/34627/diff/
>
>
> Testing
> -------
>
> Tested the patch to work on live cluster
> verified that all unit tests passes successfully
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate
to the current wizard page when another window is open
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/
-----------------------------------------------------------
(Updated May 26, 2015, 9:10 p.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11359
https://issues.apache.org/jira/browse/AMBARI-11359
Repository: ambari
Description
-------
STR:
Navigate through the Create Widget Wizard.
Once it reach metrics and expression page close the browser window
Open another browser window
Expected behavior: This should directly navigate to metrics and expression page
Actual behavior: opening another browser navigates to dashboard page. When create/edit widget is launched then it navigated to the metrics and expression page
Diffs (updated)
-----
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a
ambari-web/app/data/controller_route.js PRE-CREATION
ambari-web/app/router.js 46e62aa
Diff: https://reviews.apache.org/r/34627/diff/
Testing
-------
Tested the patch to work on live cluster
verified that all unit tests passes successfully
Thanks,
Jaimin Jetly