You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/08/03 20:31:26 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #961: feat(go/adbc/pkg): update error_details FFI
lidavidm opened a new pull request, #961:
URL: https://github.com/apache/arrow-adbc/pull/961
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #961: feat(go/adbc/pkg): update error_details FFI
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #961:
URL: https://github.com/apache/arrow-adbc/pull/961#discussion_r1283747444
##########
adbc.h:
##########
@@ -438,45 +425,7 @@ struct AdbcErrorDetail AdbcErrorGetDetail(struct AdbcError* error, int index);
/// The type is char*.
///
/// \since ADBC API revision 1.1.0
-/// \addtogroup adbc-1.1.0
#define ADBC_OPTION_PASSWORD "password"
-/// \brief Canonical option name for error details.
-///
-/// Should be used as the expected option name to retrieve error
-/// details from the driver. This allows drivers to return custom,
-/// structured error information (for example, JSON or Protocol
-/// Buffers) that can be optionally parsed by clients, beyond the
-/// standard AdbcError fields, without having to encode it in the
-/// error message. The encoding of the data is driver-defined.
-/// Drivers may provide multiple error details.
-///
Review Comment:
Ah sorry. A bit discombobulated, this all makes sense now haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #961: feat(go/adbc/pkg): update error_details FFI
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #961:
URL: https://github.com/apache/arrow-adbc/pull/961#discussion_r1283697910
##########
adbc.h:
##########
@@ -438,45 +425,7 @@ struct AdbcErrorDetail AdbcErrorGetDetail(struct AdbcError* error, int index);
/// The type is char*.
///
/// \since ADBC API revision 1.1.0
-/// \addtogroup adbc-1.1.0
#define ADBC_OPTION_PASSWORD "password"
-/// \brief Canonical option name for error details.
-///
-/// Should be used as the expected option name to retrieve error
-/// details from the driver. This allows drivers to return custom,
-/// structured error information (for example, JSON or Protocol
-/// Buffers) that can be optionally parsed by clients, beyond the
-/// standard AdbcError fields, without having to encode it in the
-/// error message. The encoding of the data is driver-defined.
-/// Drivers may provide multiple error details.
-///
Review Comment:
yes, that was the whole point of the past few days of discussion...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #961: feat(go/adbc/pkg): update error_details FFI
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #961:
URL: https://github.com/apache/arrow-adbc/pull/961#discussion_r1283695861
##########
adbc.h:
##########
@@ -438,45 +425,7 @@ struct AdbcErrorDetail AdbcErrorGetDetail(struct AdbcError* error, int index);
/// The type is char*.
///
/// \since ADBC API revision 1.1.0
-/// \addtogroup adbc-1.1.0
#define ADBC_OPTION_PASSWORD "password"
-/// \brief Canonical option name for error details.
-///
-/// Should be used as the expected option name to retrieve error
-/// details from the driver. This allows drivers to return custom,
-/// structured error information (for example, JSON or Protocol
-/// Buffers) that can be optionally parsed by clients, beyond the
-/// standard AdbcError fields, without having to encode it in the
-/// error message. The encoding of the data is driver-defined.
-/// Drivers may provide multiple error details.
-///
Review Comment:
was this intended to be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #961: feat(go/adbc/pkg): update error_details FFI
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #961:
URL: https://github.com/apache/arrow-adbc/pull/961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org