[jira] [Commented] (YETUS-53) Wrong function names in test-patch bigtop personality

["Kengo Seki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935888#comment-14935888 ] 

Kengo Seki commented on YETUS-53:
---------------------------------

I changed my mind. We should disable this feature at least for now, as originally Allen said. {{gradlew toolchain}} deletes all files under /tmp and /usr/src, so test-patch will fail because its patch-dir is also removed.

{code:title=bigtop_toolchain/manifests/cleanup.pp}
 23   exec { 'remove archives':
 24     cwd         => '/tmp',
 25     command     => '/bin/bash -c "rm -rf /tmp/* ; rm -f /usr/src/* ; exit 0"'
 26   }
{code}

I think we can simply remove this option and the corresponding functions, because we can restore them from git history if we need.

> Wrong function names in test-patch bigtop personality
> -----------------------------------------------------
>
>                 Key: YETUS-53
>                 URL: https://issues.apache.org/jira/browse/YETUS-53
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Kengo Seki
>
> In dev-support/personality/bigtop.sh:
> {code}
>  51 function bigtop_precheck_postinstall
>  52 {
>  53   if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then
>  54     pushd "${BASEDIR}" >/dev/null
>  55     echo_and_redirect "${PATCH_DIR}/bigtop-branch-toolchain.txt" "${GRADLEW}" toolchain
>  56     popd >/dev/null
>  57   fi
>  58 }
>  59 
>  60 function bigtop_postapply_postinstall
>  61 {
>  62   if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then
>  63     pushd "${BASEDIR}" >/dev/null
>  64     echo_and_redirect "${PATCH_DIR}/bigtop-patch-toolchain.txt" "${GRADLEW}" toolchain
>  65     popd >/dev/null
>  66   fi
>  67 }
> {code}
> Their names are not proper for test-patch plugin callback functions. Maybe it should be like:
> {code}
> function bigtop_precompile
> {
>   declare codebase=$1
>   if [[ ${BIGTOP_PUPPETSETUP} = "true" && ( ${codebase} = "branch" || ${codebase} = "patch" ) ]]; then
>     pushd "${BASEDIR}" >/dev/null
>     echo_and_redirect "${PATCH_DIR}/bigtop-${codebase}-toolchain.txt" "${GRADLEW}" toolchain
>     popd >/dev/null
>   fi  
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)