You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by sa...@apache.org on 2014/07/25 13:16:52 UTC

git commit: updated refs/heads/master to 8aeefdc

Repository: cloudstack
Updated Branches:
  refs/heads/master 343943fd4 -> 8aeefdc13


Fixed Coverity Issues Reported


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8aeefdc1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8aeefdc1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8aeefdc1

Branch: refs/heads/master
Commit: 8aeefdc130f1ffeae350c79c272ef254f93b9934
Parents: 343943f
Author: Santhosh Edukulla <sa...@gmail.com>
Authored: Fri Jul 25 16:46:20 2014 +0530
Committer: Santhosh Edukulla <sa...@gmail.com>
Committed: Fri Jul 25 16:46:20 2014 +0530

----------------------------------------------------------------------
 engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8aeefdc1/engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java b/engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java
index caf3b42..aad5162 100644
--- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java
+++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java
@@ -22,6 +22,7 @@ import java.sql.Connection;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import org.apache.log4j.Logger;
 
@@ -80,8 +81,8 @@ public class Upgrade440to450 implements DbUpgrade {
         uniqueKeys.put("storage_pool", keys);
 
         s_logger.debug("Droping id_2 key from storage_pool table");
-        for (String tableName : uniqueKeys.keySet()) {
-            DbUpgradeUtils.dropKeysIfExist(conn, tableName, uniqueKeys.get(tableName), false);
+        for (Map.Entry<String, List<String>> entry: uniqueKeys.entrySet()) {
+            DbUpgradeUtils.dropKeysIfExist(conn,entry.getKey(), entry.getValue(), false);
         }
     }
 }