You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by michaelarusso <gi...@git.apache.org> on 2015/12/04 09:43:35 UTC
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
GitHub user michaelarusso opened a pull request:
https://github.com/apache/usergrid/pull/447
Add additional functionality in REST layer for checking permissions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelarusso/usergrid rest-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/usergrid/pull/447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #447
----
commit 7ddf0f46e0b33951bd2fa534f2cb100b6b93b48e
Author: Michael Russo <mi...@gmail.com>
Date: 2015-12-04T08:42:17Z
Add additional functionality in REST layer for checking permissions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
Posted by michaelarusso <gi...@git.apache.org>.
Github user michaelarusso commented on the pull request:
https://github.com/apache/usergrid/pull/447#issuecomment-162019594
Read repair is being temporarily removed until we can test/validate further. Good catch on the tests. Fixing that now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/usergrid/pull/447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
Posted by mdunker <gi...@git.apache.org>.
Github user mdunker commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/447#discussion_r46710783
--- Diff: stack/rest/src/main/java/org/apache/usergrid/rest/applications/ApplicationResource.java ---
@@ -38,6 +38,7 @@
import javax.ws.rs.core.Response;
import javax.ws.rs.core.UriInfo;
+import org.apache.usergrid.rest.security.annotations.CheckPermissionsForPath;
--- End diff --
this is not used in ApplicationResource.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
Posted by snoopdave <gi...@git.apache.org>.
Github user snoopdave commented on the pull request:
https://github.com/apache/usergrid/pull/447#issuecomment-161992251
Looks good overall, but why do we need to disable read-repairs?
If we have to disable read repairs we should mark the tests that fail (see below) with the Ignore annotation and a comment that explains it.
Failed tests:
ServiceRequestIT.testRepairOfSingleEntity:160 Create call should have worked
ServiceRequestIT.testRepairOfMultipleEntitiesAndRemainingEntities:313 null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Add additional functionality in REST layer ...
Posted by michaelarusso <gi...@git.apache.org>.
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/447#discussion_r46711226
--- Diff: stack/rest/src/main/java/org/apache/usergrid/rest/applications/ApplicationResource.java ---
@@ -38,6 +38,7 @@
import javax.ws.rs.core.Response;
import javax.ws.rs.core.UriInfo;
+import org.apache.usergrid.rest.security.annotations.CheckPermissionsForPath;
--- End diff --
fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---