You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/08 21:56:37 UTC
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
slawekjaranowski opened a new pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033467305
https://issues.apache.org/jira/browse/MSHADE-182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#discussion_r803196572
##########
File path: surefire-its/src/test/resources/surefire-2006-shadefire-transformers/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-2006</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <name>shadefire usage test</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
Review comment:
Here we can open more alternatives for test errors if we build the sources against `${java.specificaation.version}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033227529
It's good that you have looked at it.
After checking the original content of the JAR, the SPI was there 4 times and the sources too.
Now it is without duplicates of `*.class` and SPI?
The POJO test should not be modified like this because the users will not use the `ShadeFire` provider. This provider was developed mainly for our internal purposes. The POJO does not need to have any JUnit dependency and no provider because it assumes that the tests are so simple where the public test methods start with name `test`.
Anyway, if you like to test the `ShadeFire`, it's good but we should also keep the original IT and this can be accomplished by adding a new Maven profile for ShadeFire in the IT's POM which is maybe the most simple solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1034081075
Fixed:
- there are no duplicated services
- new IT test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033474843
- *.class are not duplicated
- we have one additional service - from original jar - MasterProcessChannelProcessorFactory
```
shade/META-INF/services/
├── org.apache.maven.shadefire.surefire.spi.MasterProcessChannelProcessorFactory
├── org.apache.maven.surefire.api.provider.SurefireProvider
└── org.apache.maven.surefire.spi.MasterProcessChannelProcessorFactory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033502358
I will fix duplicate services and prepare separate IT test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#discussion_r803385871
##########
File path: surefire-its/src/test/resources/surefire-2006-shadefire-transformers/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-2006</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <name>shadefire usage test</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
Review comment:
What is your proposition?
Most of IT tests have the same, even with 1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033229699
Maybe it is a bug in the `maven-shade-plugin`, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski edited a comment on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
slawekjaranowski edited a comment on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033474843
- *.class are not duplicated
- we have one additional service - from original jar - MasterProcessChannelProcessorFactory
```
shade/META-INF/services/
├── org.apache.maven.shadefire.surefire.spi.MasterProcessChannelProcessorFactory
├── org.apache.maven.surefire.api.provider.SurefireProvider
└── org.apache.maven.surefire.spi.MasterProcessChannelProcessorFactory
```
I hope it is not issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#discussion_r803520482
##########
File path: surefire-its/src/test/resources/surefire-2006-shadefire-transformers/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-2006</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <name>shadefire usage test</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
Review comment:
The old tests with j7 are old tests, that's the history.
Once, Robert Scholte provided an integration test with
```
<maven.compiler.source>${java.specificaation.version}</maven.compiler.source>
<maven.compiler.target>${java.specificaation.version}</maven.compiler.target>
```
It was very interesting configuration. We know that the bytecode is not always the same beween versions which is good for us because we can find more bug in these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#discussion_r803520482
##########
File path: surefire-its/src/test/resources/surefire-2006-shadefire-transformers/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-2006</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <name>shadefire usage test</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
Review comment:
The old tests with j7 are old tests, that's the history.
Once, Robert Scholte provided an integration test with
```
<maven.compiler.source>${java.specificaation.version}</maven.compiler.source>
<maven.compiler.target>${java.specificaation.version}</maven.compiler.target>
```
It was very interesting configuration. We know that the bytecode is not always the same beween versions which is good for us because we can find more bugs in these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033495119
Anyway, if you like to test the ShadeFire, it's good but we should also keep the original IT and this can be accomplished by adding a new Maven profile for ShadeFire in the IT's POM which is maybe the most simple solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033227529
Good that you have made a look into it.
After checking the original content of the JAR, the SPI was there 4 times and the sources too.
Now it is without duplicates of `*.class` and SPI?
The POJO test should not be modified like this because the users will not use the `ShadeFire` provider. This provider was developed mainly for our internal purposes. The POJO does not need to have any JUnit dependency and no provider because it assumes that the tests are so simple where the public test methods start with name `test`.
Anyway, if you like to test the `ShadeFire`, it's good but we should also keep the original IT and this can be accomplished by adding a new Maven profile for ShadeFire in the IT's POM which is maybe the most simple solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org