You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-dev@hadoop.apache.org by "Luke Lu (JIRA)" <ji...@apache.org> on 2011/02/18 00:37:12 UTC

[jira] Created: (MAPREDUCE-2335) mapreduce.CounterGroup constructor should not be public

mapreduce.CounterGroup constructor should not be public
-------------------------------------------------------

                 Key: MAPREDUCE-2335
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2335
             Project: Hadoop Map/Reduce
          Issue Type: Bug
            Reporter: Luke Lu


MAPREDUCE-980 (made into 0.21+) changed the constructor from package protected to public. As we all know: nothing good happens after making a constructor public, especially for public facing APIs. There is no other use of the constructor outside the EventReader yet. To avoid another API change debacle in case of external user usage and later we decide to refactor counters for more efficient internal implementations (e.g. a la MAPREDUCE-901), we should make the Counter/CounterGroup constructors package private, and provide a method to addGroup to Counters. Or at least make the constructor @InterfaceAudience.Private.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira