You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2020/06/03 20:43:51 UTC
[kafka] 01/02: MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch 2.6
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit 91f9c2652f5833817f826690b70fc597de9bc223
Author: showuon <43...@users.noreply.github.com>
AuthorDate: Thu Jun 4 04:17:31 2020 +0800
MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
Upgrade spotbugsPlugin to have clear output indicating where the error is.
When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It doesn't even tell you where the error is and how many errors found, it will take a lot of time for the developers to find out where the error is, and then fix it.
https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/
Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x
https://github.com/spotbugs/spotbugs-gradle-plugin/issues/210
So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is like this:
So you know there's 1 error and you can also open the report file to find out the error.
Upgraded to the latest bug fix release of spotbugs (4.0.3) while at it.
Reviewers: Ismael Juma <is...@juma.me.uk>
---
gradle/dependencies.gradle | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 294d0c4..d803f1c 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -111,8 +111,8 @@ versions += [
shadowPlugin: "5.2.0",
slf4j: "1.7.30",
snappy: "1.1.7.3",
- spotbugs: "4.0.2",
- spotbugsPlugin: "4.0.5",
+ spotbugs: "4.0.3",
+ spotbugsPlugin: "4.2.4",
spotlessPlugin: "3.28.1",
testRetryPlugin: "1.1.5",
zinc: "1.3.5",