You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/07/05 06:43:38 UTC
Review Request 67831: ATLAS-2777: Enhance advanced search (DSL) to
support
classification search on _CLASSIFIED or _NOT_CLASSIFIED keyword
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67831/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2777
https://issues.apache.org/jira/browse/ATLAS-2777
Repository: atlas
Description
-------
ATLAS-2775 introduced keywords - CLASSIFIED and NOT_CLASSIFIED on basic search to search on entities with ANY classifications or NO classifications.
This JIRA supports the same keywords in advanced search (DSL).
Diffs
-----
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434c
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 9ad9a6e41
repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 78ab206d3
Diff: https://reviews.apache.org/r/67831/diff/1/
Testing
-------
Manually tested in Advaced search the following DSL queries:
`_CLASSIFIED`, '_CLASSIFIED'
`_NOT_CLASSIFIED`, 'NOT__CLASSIFIED'
hive_table isa _CLASSIFIED
hive_column isa NOT_CLASSIFIED
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/504/console
Thanks,
Sarath Subramanian
Re: Review Request 67831: ATLAS-2777: Enhance advanced search (DSL) to
support classification search on _CLASSIFIED or _NOT_CLASSIFIED keyword
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67831/#review205749
-----------------------------------------------------------
Can you please add unit test(s) to cover this case?
- Ashutosh Mestry
On July 5, 2018, 6:43 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67831/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 6:43 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2777
> https://issues.apache.org/jira/browse/ATLAS-2777
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2775 introduced keywords - CLASSIFIED and NOT_CLASSIFIED on basic search to search on entities with ANY classifications or NO classifications.
>
> This JIRA supports the same keywords in advanced search (DSL).
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434c
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 9ad9a6e41
> repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 78ab206d3
>
>
> Diff: https://reviews.apache.org/r/67831/diff/1/
>
>
> Testing
> -------
>
> Manually tested in Advaced search the following DSL queries:
> `_CLASSIFIED`, '_CLASSIFIED'
> `_NOT_CLASSIFIED`, 'NOT__CLASSIFIED'
> hive_table isa _CLASSIFIED
> hive_column isa NOT_CLASSIFIED
>
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/504/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67831: ATLAS-2777: Enhance advanced search (DSL) to
support classification search on _CLASSIFIED or _NOT_CLASSIFIED keyword
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67831/#review205734
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 5, 2018, 6:43 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67831/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 6:43 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2777
> https://issues.apache.org/jira/browse/ATLAS-2777
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2775 introduced keywords - CLASSIFIED and NOT_CLASSIFIED on basic search to search on entities with ANY classifications or NO classifications.
>
> This JIRA supports the same keywords in advanced search (DSL).
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434c
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 9ad9a6e41
> repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 78ab206d3
>
>
> Diff: https://reviews.apache.org/r/67831/diff/1/
>
>
> Testing
> -------
>
> Manually tested in Advaced search the following DSL queries:
> `_CLASSIFIED`, '_CLASSIFIED'
> `_NOT_CLASSIFIED`, 'NOT__CLASSIFIED'
> hive_table isa _CLASSIFIED
> hive_column isa NOT_CLASSIFIED
>
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/504/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>