You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2024/05/22 08:57:40 UTC
[PR] Change to Base64 urlEncoder/urlDecoder for handle guid and credential [kyuubi]
wForget opened a new pull request, #6408:
URL: https://github.com/apache/kyuubi/pull/6408
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #
## Describe Your Solution ๐ง
`Base64.getMimeEncoder` might generate newline, so I changed it to` Base64.getUrlEncoder`. Only changing for handle guid and credential.
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklist ๐
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Change to Base64 urlEncoder/urlDecoder for handle guid and credential [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6408:
URL: https://github.com/apache/kyuubi/pull/6408#discussion_r1609592128
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -797,8 +797,8 @@ private void openSession() throws SQLException {
if (launchEngineOpHandleGuid != null && launchEngineOpHandleSecret != null) {
try {
- byte[] guidBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleGuid);
- byte[] secretBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleSecret);
+ byte[] guidBytes = Base64.getUrlDecoder().decode(launchEngineOpHandleGuid);
Review Comment:
this looks like a breaking change, we should support older/newer JDBC client to access newer/older Kyuubi Server, are they compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Change to Base64 urlEncoder/urlDecoder for handle guid and credential [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6408:
URL: https://github.com/apache/kyuubi/pull/6408#discussion_r1609622722
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -797,8 +797,8 @@ private void openSession() throws SQLException {
if (launchEngineOpHandleGuid != null && launchEngineOpHandleSecret != null) {
try {
- byte[] guidBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleGuid);
- byte[] secretBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleSecret);
+ byte[] guidBytes = Base64.getUrlDecoder().decode(launchEngineOpHandleGuid);
Review Comment:
I read the RFC4648 and RFC2045, as the length won't exceeds `MIMELINEMAX=76`, it should be fine here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Change to Base64 urlEncoder/urlDecoder for handle guid and credential [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6408:
URL: https://github.com/apache/kyuubi/pull/6408#discussion_r1609622722
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -797,8 +797,8 @@ private void openSession() throws SQLException {
if (launchEngineOpHandleGuid != null && launchEngineOpHandleSecret != null) {
try {
- byte[] guidBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleGuid);
- byte[] secretBytes = Base64.getMimeDecoder().decode(launchEngineOpHandleSecret);
+ byte[] guidBytes = Base64.getUrlDecoder().decode(launchEngineOpHandleGuid);
Review Comment:
I read the RFC4648 and RFC2045, as the length won't exceeds `MIMELINEMAX=76`, `Encoder.getDecoder` should be fine here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Change to Base64 RFC4648 for handle guid and credential [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #6408:
URL: https://github.com/apache/kyuubi/pull/6408#issuecomment-2124374469
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Change to Base64 RFC4648 for handle guid and credential [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #6408: Change to Base64 RFC4648 for handle guid and credential
URL: https://github.com/apache/kyuubi/pull/6408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org