You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by tintoy <gi...@git.apache.org> on 2018/02/07 23:07:14 UTC

[GitHub] libcloud pull request #1171: Fix IndexError in dimensiondata list_images

GitHub user tintoy opened a pull request:

    https://github.com/apache/libcloud/pull/1171

    Fix IndexError in dimensiondata list_images

    ## Fix IndexError in dimensiondata list_images
    
    ### Description
    
    This fix involves filtering out images from locations not returned by the list_locations API.
    
    This is required because the CloudControl API returns all images in the target geographic region (even ones in datacenters the user's organisation does not have access to).
    
    We therefore need to filter out those images (since we can't get a NodeLocation for them).
    
    ### Status
    
    Done, ready for review.
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DimensionDataResearch/libcloud fix/dimensiondata_list_images

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1171
    
----
commit 1f2143f72a3a77c79e8060b4c31d97fe801d09d2
Author: Adam Friedman <ti...@...>
Date:   2018-02-07T23:00:50Z

    Fix IndexError in dimensiondata list_images.
    
    Fix involves filtering out images from locations not returned by the list_locations API.
    
    This is required because the CloudControl API returns all images in the
    target geographic region (even ones in datacenters the user's
    organisation does not have access to).
    
    We therefore need to filter out those images (since we can't get a
    NodeLocation for them).

----


---

[GitHub] libcloud pull request #1171: Fix IndexError in dimensiondata list_images

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1171


---