You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/03/22 02:14:41 UTC
Review Request 45143: AMBARI-15504. Host filter: minor UX edits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45143/
-----------------------------------------------------------
Review request for Ambari and Xi Wang.
Bugs: AMBARI-15504
https://issues.apache.org/jira/browse/AMBARI-15504
Repository: ambari
Description
-------
Various UI fixes for combo search box.
Diffs
-----
ambari-web/app/messages.js 421143a
ambari-web/app/styles/application.less 7bf94e2
ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4
ambari-web/app/views/main/host/combo_search_box.js 2f86485
Diff: https://reviews.apache.org/r/45143/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
24635 tests complete (22 seconds)
145 tests pending
Thanks,
Richard Zang
Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45143/#review124892
-----------------------------------------------------------
Ship it!
Ship It!
- Xi Wang
On March 22, 2016, 2:09 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45143/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 2:09 p.m.)
>
>
> Review request for Ambari and Xi Wang.
>
>
> Bugs: AMBARI-15504
> https://issues.apache.org/jira/browse/AMBARI-15504
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Various UI fixes for combo search box.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js 52e3b8e
> ambari-web/app/styles/application.less 7bf94e2
> ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4
> ambari-web/app/views/main/host/combo_search_box.js 2f86485
> ambari-web/test/views/main/host/combo_search_box_test.js 9c2e7b6
>
> Diff: https://reviews.apache.org/r/45143/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster. All unit tests passed.
> 24635 tests complete (22 seconds)
> 145 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45143/
-----------------------------------------------------------
(Updated March 22, 2016, 9:09 p.m.)
Review request for Ambari and Xi Wang.
Changes
-------
Fix unit test
Bugs: AMBARI-15504
https://issues.apache.org/jira/browse/AMBARI-15504
Repository: ambari
Description
-------
Various UI fixes for combo search box.
Diffs (updated)
-----
ambari-web/app/messages.js 52e3b8e
ambari-web/app/styles/application.less 7bf94e2
ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4
ambari-web/app/views/main/host/combo_search_box.js 2f86485
ambari-web/test/views/main/host/combo_search_box_test.js 9c2e7b6
Diff: https://reviews.apache.org/r/45143/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
24635 tests complete (22 seconds)
145 tests pending
Thanks,
Richard Zang