You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 22:19:44 UTC

[GitHub] [spark] Gaurangi94 opened a new pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Gaurangi94 opened a new pull request #29629:
URL: https://github.com/apache/spark/pull/29629


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] tgravescs commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686485520


   so I'm a little worried this is going to clutter the UI and not be useful in many situations. the driver host on very large clusters could be any number of thousands of hosts and I don't see its usefulness on the top level page in a normal single cluster instance, people use the app id.   So even here, you are using the host name to indicate what cluster, but what are you using that for?  Just sorting?
   
   also you may have your hostnames setup so that you can tell the cluster, but others may not, it might just be host1.foo.com, host2.foo.com, etc.   Are you running in standalone mode?  Wouldn't master node be more useful and reliable? 
   
   either way if we do allow this we may consider adding a toggle button to not show in my cases.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] tgravescs commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686495293


   note this is related to https://github.com/apache/spark/pull/29630 to add support for multiple clusters to history server


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-687552574


   cc @gengliangwang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686059167


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686216637


   @Gaurangi94 can you show a screenshot after this fix?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-747802125


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686059167


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Gaurangi94 commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
Gaurangi94 commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686313640


   > @Gaurangi94 can you show a screenshot after this fix?
   
   The screenshot is in the JIRA filed by us.  https://issues.apache.org/jira/browse/SPARK-32135


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Gaurangi94 commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
Gaurangi94 commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-688994938


   > so I'm a little worried this is going to clutter the UI and not be useful in many situations. the driver host on very large clusters could be any number of thousands of hosts and I don't see its usefulness on the top level page in a normal single cluster instance, people use the app id. So even here, you are using the host name to indicate what cluster, but what are you using that for? Just sorting?
   > 
   > also you may have your hostnames setup so that you can tell the cluster, but others may not, it might just be host1.foo.com, host2.foo.com, etc. Are you running in standalone mode? Wouldn't master node be more useful and reliable?
   > 
   > either way if we do allow this we may consider adding a toggle button to not show in my cases.
   
   
   
   > so I'm a little worried this is going to clutter the UI and not be useful in many situations. the driver host on very large clusters could be any number of thousands of hosts and I don't see its usefulness on the top level page in a normal single cluster instance, people use the app id. So even here, you are using the host name to indicate what cluster, but what are you using that for? Just sorting?
   > 
   > also you may have your hostnames setup so that you can tell the cluster, but others may not, it might just be host1.foo.com, host2.foo.com, etc. Are you running in standalone mode? Wouldn't master node be more useful and reliable?
   > 
   > either way if we do allow this we may consider adding a toggle button to not show in my cases.
   
   Hello,
   
   I have updated the description of my PR to better describe our use-case. Apologies for the confusion here. We could add master node too if that seems to be better applicable to other use-cases as well.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] closed pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29629:
URL: https://github.com/apache/spark/pull/29629


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29629: [SPARK-32135] Show Spark Driver name on Spark history web page

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686061121


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org