[GitHub] [accumulo] milleruntime commented on pull request #2827: refactor GarbageCollectionLogger so one instance per context

[GitBox <gi...@apache.org>]

milleruntime commented on PR #2827:
URL: https://github.com/apache/accumulo/pull/2827#issuecomment-1195458555

   While I appreciate the attempt to improve the use of this class, I really think the logic of this class should exist in the `TabletServerResourceManager`. I am not sure how exactly it would be incorporated with the other memory checks but we have a `memoryGuardThread` already running in the tserver. This thread is more geared towards `Tablet` memory usage but I feel like the Java GC checking thread here should be running with the other resource management of the tserver. The `GarbageCollectionLogger` class feels like it was just created quickly on the fly to try for debugging a complex production issue and just thrown into the tserver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org