You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Marat Radchenko (JIRA)" <ji...@apache.org> on 2007/08/31 09:58:30 UTC
[jira] Created: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
There is no way to specify what exceptions to log in RequestCycle
-----------------------------------------------------------------
Key: WICKET-908
URL: https://issues.apache.org/jira/browse/WICKET-908
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Marat Radchenko
Priority: Critical
RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
Posted by "Marat Radchenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marat Radchenko updated WICKET-908:
-----------------------------------
Description:
RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
was:
RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> There is no way to specify what exceptions to log in RequestCycle
> -----------------------------------------------------------------
>
> Key: WICKET-908
> URL: https://issues.apache.org/jira/browse/WICKET-908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Marat Radchenko
> Priority: Critical
>
> RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
> So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
> Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524260 ]
Juergen Donnerstag commented on WICKET-908:
-------------------------------------------
sorry, I reverted that change. logRuntimeExcpeiton can be replace easily already.
> There is no way to specify what exceptions to log in RequestCycle
> -----------------------------------------------------------------
>
> Key: WICKET-908
> URL: https://issues.apache.org/jira/browse/WICKET-908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Marat Radchenko
> Assignee: Juergen Donnerstag
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
> So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
> Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
Posted by "Chuck Deal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524727 ]
Chuck Deal commented on WICKET-908:
-----------------------------------
This didn't get reverted properly. The logic (in at least RequestCycle) got inverted.
IS:
if (e instanceof PageExpiredException)
{
logRuntimeException(e);
}
WAS (and should be):
if (!(e instanceof PageExpiredException))
{
logRuntimeException(e);
}
> There is no way to specify what exceptions to log in RequestCycle
> -----------------------------------------------------------------
>
> Key: WICKET-908
> URL: https://issues.apache.org/jira/browse/WICKET-908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Marat Radchenko
> Assignee: Juergen Donnerstag
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
> So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
> Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
Posted by "Marat Radchenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524293 ]
Marat Radchenko commented on WICKET-908:
----------------------------------------
Oh, sorry. I didn't think about overriding logRuntimeException
> There is no way to specify what exceptions to log in RequestCycle
> -----------------------------------------------------------------
>
> Key: WICKET-908
> URL: https://issues.apache.org/jira/browse/WICKET-908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Marat Radchenko
> Assignee: Juergen Donnerstag
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
> So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
> Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-908) There is no way to specify what
exceptions to log in RequestCycle
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-908.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta4
Assignee: Juergen Donnerstag
now possible via replacing onRuntimeException
> There is no way to specify what exceptions to log in RequestCycle
> -----------------------------------------------------------------
>
> Key: WICKET-908
> URL: https://issues.apache.org/jira/browse/WICKET-908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Marat Radchenko
> Assignee: Juergen Donnerstag
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error).
> So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle).
> Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please.
> The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.