You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/26 05:06:38 UTC

[GitHub] [pulsar-client-go] michaeljmarshall commented on a diff in pull request #809: [issue #807] dlq topic producer options

michaeljmarshall commented on code in PR #809:
URL: https://github.com/apache/pulsar-client-go/pull/809#discussion_r955653135


##########
pulsar/dlq_router.go:
##########
@@ -135,12 +135,16 @@ func (r *dlqRouter) getProducer(schema Schema) Producer {
 	// Retry to create producer indefinitely
 	backoff := &internal.Backoff{}
 	for {
-		producer, err := r.client.CreateProducer(ProducerOptions{
-			Topic:                   r.policy.DeadLetterTopic,
-			CompressionType:         LZ4,
-			BatchingMaxPublishDelay: 100 * time.Millisecond,

Review Comment:
   Is there a reason we disabled batching by default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org