You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ashish Paliwal <pa...@gmail.com> on 2015/01/19 04:33:36 UTC
Re: Review Request 16151: Patch for FLUME-2006 - in Avro the batch
size is called batch-size, in all other sources batchSize
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16151/
-----------------------------------------------------------
(Updated Jan. 19, 2015, 3:33 a.m.)
Review request for Flume.
Bugs: FLUME-2006
https://issues.apache.org/jira/browse/FLUME-2006
Repository: flume-git
Description
-------
Patch based on discussion on JIRA
1. If batch-size is present, a warning is logged to to use batchSize
2. If both, batch-size and batchSize are present, an Exception is thrown, recommending to use batchSize
3. batch-size property has been marked as deprecated
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java 5146834
flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 757a536
flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java 357965f
flume-ng-sdk/src/main/java/org/apache/flume/api/FailoverRpcClient.java db6905a
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 3661672
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java 33a2330
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 11bc94c
flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java 6382a0e
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java cf4f415
flume-ng-sdk/src/test/java/org/apache/flume/api/TestThriftRpcClient.java a8baaa8
Diff: https://reviews.apache.org/r/16151/diff/
Testing
-------
Existing test cases which use batch-size pass
Added test case to check behaviour if both properties are present
Thanks,
Ashish Paliwal