You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2008/11/12 17:43:44 UTC
[jira] Created: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Use annotations instead of excluding tests in pom.xml
-----------------------------------------------------
Key: OPENJPA-770
URL: https://issues.apache.org/jira/browse/OPENJPA-770
Project: OpenJPA
Issue Type: Sub-task
Affects Versions: 2.0.0
Reporter: Michael Dick
Fix For: 2.0.0
In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
The list of excluded tests can be found in pom.xml, here's a subsection of them
<!-- exclude new tests that aren't passing yet -->
<exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
<exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
<exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
<exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by Jeremy Bauer <te...@gmail.com>.
-1
The extra build time expense is much too high. I've borrowed code from the
excluded tests on occasion, so purging them wouldn't be a good solution
either, IMO.
-Jeremy
On Fri, Feb 20, 2009 at 1:53 PM, Michael Dick (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675454#action_12675454]
>
> Michael Dick commented on OPENJPA-770:
> --------------------------------------
>
> I didn't realize the test exclusions would add that much time. I vote for
> leaving well enough alone - spending an additional 40 -50 minutes per build
> with no tangible benefit doesn't sound good to me.
>
> I appreciate the patch, and I would like to get rid of the long list of
> exclusions, but not at that price.
>
> > Use annotations instead of excluding tests in pom.xml
> > -----------------------------------------------------
> >
> > Key: OPENJPA-770
> > URL: https://issues.apache.org/jira/browse/OPENJPA-770
> > Project: OpenJPA
> > Issue Type: Sub-task
> > Affects Versions: 2.0.0
> > Reporter: Michael Dick
> > Assignee: Tim McConnell
> > Fix For: 2.0.0
> >
> > Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch,
> OPENJPA-770.patch
> >
> > Original Estimate: 3h
> > Remaining Estimate: 3h
> >
> > In openjpa-persistence-jdbc/pom.xml there are a lot of excluded
> testcases. Instead of hard coding these in pom.xml we should use the new
> annotation that Pinaki introduced in the "parent" JIRA issue.
> > The list of excluded tests can be found in pom.xml, here's a subsection
> of them
> > <!-- exclude new tests that aren't passing yet -->
> >
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> >
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> >
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> >
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-770:
----------------------------------
Attachment: OPENJPA-770-2.patch
Hi Albert, thanks much for reviewing. I've attached another patch which includes your recommendations.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675454#action_12675454 ]
Michael Dick commented on OPENJPA-770:
--------------------------------------
I didn't realize the test exclusions would add that much time. I vote for leaving well enough alone - spending an additional 40 -50 minutes per build with no tangible benefit doesn't sound good to me.
I appreciate the patch, and I would like to get rid of the long list of exclusions, but not at that price.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-770:
----------------------------------
Attachment: OPENJPA-770.patch
Hi, I've attached a patch for this JIRA for review, comments, and hopefully inclusion. Please consider these points when reviewing the patch:
1. The @AllowFailure annotation was added (almost exclusively at the method level) to the testcases that were previously excluded in the pom.xml.
2. Some of the testcases that were previously excluded in the pom.xml are now working, in which case I did not alter them
3. Some testcases were repaired for other reasons. Most notably, testcases were repaired so as not to fail the build (e.g., NullPointerExceptions were fixed, and testcases with no tests were repaired).
4. Finally, I re-ordered all the imports in the classes that I touched, but I decided not to include those changes in the patch so as not to confuse the reviewer. I can easily attach that patch though if it would not be frowned upon.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-770:
----------------------------------
Assignee: Tim McConnell
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by "Albert Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673263#action_12673263 ]
Albert Lee commented on OPENJPA-770:
------------------------------------
Tim, I took a look at the patch, It does what is asked for in the original request.
To keep the changes cleaner and to a minimum, I wonder a class level @AllowFailure can be applied to some of these tests instead of annotating in every method. Also consider the use of @AllowFailure(value=false) to negate test selection and/or exclusions.
Thanks for the patch.
Albert Lee.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by "Pinaki Poddar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669974#action_12669974 ]
Pinaki Poddar commented on OPENJPA-770:
---------------------------------------
A small utility is available to find all tests that are marked with @AllowFailure. It is general purpose to detect other kinds of things but its main() is hardcoded for its original purpose.
The following small script should show how this works:
1. Go to root of OpenJPA directory
2. Execute the following
@setlocal
set SERP_JAR=c:\Documents and Settings\Administrator\.m2\repository\net\sourceforge\serp\serp\1.13.1\serp-1.13.1.jar
SET CLASSPATH=openjpa-persistence-jdbc\target\test-classes;%SERP_JAR%
java org.apache.openjpa.persistence.test.ClassSelector
@endlocal
3. It prints something like this on console:
Found 3 classes under C:\work\openjpa-1.3.0 that
extends org.apache.openjpa.persistence.test.SingleEMTestCase
or org.apache.openjpa.persistence.test.SingleEMFTestCase
or org.apache.openjpa.persistence.kernel.BaseKernelTest
or org.apache.openjpa.persistence.query.BaseQueryTest
or org.apache.openjpa.persistence.jdbc.kernel.BaseJDBCTest
or org.apache.openjpa.persistence.common.utils.AbstractTestCase
and annotatated with org.apache.openjpa.persistence.test.AllowFailure
org.apache.openjpa.persistence.jdbc.annotations.TestSequenceGenerator
org.apache.openjpa.persistence.jdbc.query.TestQueryParameterBinding
org.apache.openjpa.persistence.kernel.TestInitialValueFetching
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675486#action_12675486 ]
Donald Woods commented on OPENJPA-770:
--------------------------------------
So why do we have so many junit tests that we aren't using? Maybe its time to delete them? What good are they providing if they are never executed?
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-770:
----------------------------------
Attachment: OPENJPA-770-3.patch
Patch #3 attached to fix problem no tests found in TestAbstractMappedAppIdSuper
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Albert Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Albert Lee resolved OPENJPA-770.
--------------------------------
Resolution: Won't Fix
3 votes (Mike D, Jeremy B and Albert L) NOT to commit the patch due to test run duration cost if higher than acceptable.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENJPA-770) Use annotations instead of excluding
tests in pom.xml
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dick closed OPENJPA-770.
--------------------------------
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0-M2
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0-M2
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-770) Use annotations instead of
excluding tests in pom.xml
Posted by "Albert Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675445#action_12675445 ]
Albert Lee commented on OPENJPA-770:
------------------------------------
Tim, Thanks for providing the new patch.
---------------------
Other developers,
The new patch is ready but I have some hesitation in committing this changes. The reasons are:
1) The # of test grows from 1300s to 2200s tests and 149 more test classes. (Not a good reason for not committing)
2) The concern is the run duration for the mvn "test" target has grown approximately from 35 minutes to over 80 minutes on my Thinkpad.
3) If the new tests provide value in validating openjpa functions, that is great but these tests are just ran, mostly failed but ignored, then I am not too thrill in committing this change.
Please reply and vote if you think it is worth to make the changes:
+1 - commit
0 - neutral
-1 - reject
Thanks,
Albert Lee.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.