You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Chris Custine (JIRA)" <ji...@apache.org> on 2007/08/30 18:44:30 UTC
[jira] Created: (DIRSERVER-1048) Need to improve LDIF load
procedures
Need to improve LDIF load procedures
------------------------------------
Key: DIRSERVER-1048
URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
Project: Directory ApacheDS
Issue Type: Improvement
Components: core
Affects Versions: 1.5.1
Reporter: Chris Custine
Priority: Minor
Fix For: 1.5.2
The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523969 ]
Emmanuel Lecharny commented on DIRSERVER-1048:
----------------------------------------------
I don't exactly remember the reasons I said I didn't think it was a good idea ... Anyways, I'm getting old, and it may be normal that I'm loosing my memory.
What were we talking about ? errr...
Ok, I suggest we use the shared-ldap LdifReader in place of this LdifLoader which seems totally broken up to a point it needs to be patched. There are at least two big problems :
- this class is badly misplaced : what the hell is a Ldif manipulation class is doing into a protocol pakcage ?
- this ldif loader does not accept modificatiosn, when LdifReader accept plain entries _or_ modifications (this is an exclusive or, but if you just use modifications, you can also inject entries, assuming you use the 'add' changetype)
In my mind, using the shared-ldap ldif file should do the trick.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523972 ]
David Jencks commented on DIRSERVER-1048:
-----------------------------------------
LdifFileLoader uses LdifReader to read the ldif file, it just ignores all the modification entries. ldifReader just turns the ldif file into a bunch of attributes or modification items, the LdifFileLoader sends (some of) them to the server.
I found LdifFileLoader because it is used by the StartupConfiguration ldifDirectory feature.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523885 ]
Chris Custine commented on DIRSERVER-1048:
------------------------------------------
Well, like David said in this email, it just skips modify sections. Ersin also looked at it and found the issue but I have not looked at it directly. David and I also remember you saying on IRC that there was a reason why the fix was not a good idea, but I can't recall what it was.
http://www.nabble.com/Initializing-ldap-%22applications%22-tf4344888.html#a12378395
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523973 ]
Emmanuel Lecharny commented on DIRSERVER-1048:
----------------------------------------------
Damn, not only I'm loosing my memory, but I'm also becoming stupid...
Ok, I think that the patch may be applied in 1.5.2 version.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523927 ]
David Jencks commented on DIRSERVER-1048:
-----------------------------------------
I have some simple local modifications to make LdifFileLoader deal with modification items and it works fine for me and I'd be happy to apply it but elecharny said he didn't think it was a good idea but I didn't understand why not.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-1048:
-------------------------------------
Fix Version/s: (was: 1.5.4)
1.5.5
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.5
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-1048:
-----------------------------------------
Fix Version/s: (was: 1.5.2)
1.5.3
I don't think the patch hase been applied.
Postponed.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-1048:
-------------------------------------
Fix Version/s: (was: 1.5.3)
1.5.4
Might be done - need confirmation
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.4
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523879 ]
Emmanuel Lecharny commented on DIRSERVER-1048:
----------------------------------------------
I don't see why this could not be done with the current LDIFLoader.
Do we have explicit samples which show what's wrong ?
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated DIRSERVER-1048:
------------------------------------
Attachment: DIRSERVER-1048.LdifFileLoader.patch
This patch makes LdifFileLoader work well enough for my purposes in triplesec. IIRC it doesn't implement filtering on modification items.
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRSERVER-1048.
----------------------------------------
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.5
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSERVER-1048) Need to improve LDIF load
procedures
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSERVER-1048.
------------------------------------------
Resolution: Fixed
As far as I can tell, the patch has been applied a long time ago (probably by David, on rev. 580555)
> Need to improve LDIF load procedures
> ------------------------------------
>
> Key: DIRSERVER-1048
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.1
> Reporter: Chris Custine
> Priority: Minor
> Fix For: 1.5.5
>
> Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing entries in order to add administrativeRole attributes, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.