You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/09/26 14:12:23 UTC
[GitHub] egor-ryashin commented on a change in pull request #6349:
maintenance mode for Historical
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r220579503
##########
File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -80,7 +83,9 @@ public CoordinatorDynamicConfig(
@JsonProperty("killDataSourceWhitelist") Object killDataSourceWhitelist,
@JsonProperty("killAllDataSources") boolean killAllDataSources,
@JsonProperty("killPendingSegmentsSkipList") Object killPendingSegmentsSkipList,
- @JsonProperty("maxSegmentsInNodeLoadingQueue") int maxSegmentsInNodeLoadingQueue
+ @JsonProperty("maxSegmentsInNodeLoadingQueue") int maxSegmentsInNodeLoadingQueue,
+ @JsonProperty("maintenanceList") Object maintenanceList,
+ @JsonProperty("maintenanceModeSegmentsPriority") int maintenanceModeSegmentsPriority
Review comment:
If JSON doesn't contain new fields then the object will have the empty list and ratio = 7, with the empty list Coordinator will ignore parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org