You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/27 14:36:59 UTC
[GitHub] [pinot] gortiz opened a new issue, #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
gortiz opened a new issue, #9113:
URL: https://github.com/apache/pinot/issues/9113
SegmentGenerationJobRunner.submitSegmentGenTask submits tasks to an executor. Each task has a try-catch that logs the problem and stops the execution in case a subclass of Exception is thrown. But this code does not log the problem if an Error is thrown. For example, if the JVM that executes SegmentGenerationJobRunner does not have enough heap memory to apply the generation, then Java will throw an OutOfMemoryError that will not be catched by SegmentGenerationJobRunner.submitSegmentGenTask. As a result, no log is printed to the user and the JVM continues to work. Eventually there is enough memory to sucessfully create the other segments and the process finish with a correct status but without generating some segments.
This behavior is very misleading, as the user thinks that his data is correctly stored in Pinot, when in fact some segments have been ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
URL: https://github.com/apache/pinot/issues/9113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #9113:
URL: https://github.com/apache/pinot/issues/9113#issuecomment-1199897921
@rino-kadijk It's a global catch and we are not trying to recover from it. Currently we will miss the error and the thread just died without properly propagate the error back.
Closing the issue as the fix is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] rino-kadijk commented on issue #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
Posted by GitBox <gi...@apache.org>.
rino-kadijk commented on issue #9113:
URL: https://github.com/apache/pinot/issues/9113#issuecomment-1199662891
It can be hard to recover from a JVM Error. Are you sure you want to catch and retry ALL JVM Errors including LinkageError, StackOverFlowError, IOError, etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #9113: SegmentGenerationJobRunner.submitSegmentGenTask should catch all Throwables
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #9113:
URL: https://github.com/apache/pinot/issues/9113#issuecomment-1197429314
Good catch! We should change the code to catch all `Throwable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org