You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2009/05/11 21:37:45 UTC

[jira] Created: (HBASE-1405) Threads.shutdown has unnecessary branch

Threads.shutdown has unnecessary branch
---------------------------------------

                 Key: HBASE-1405
                 URL: https://issues.apache.org/jira/browse/HBASE-1405
             Project: Hadoop HBase
          Issue Type: Improvement
            Reporter: Nitay Joffe
            Priority: Minor
             Fix For: 0.20.0


{code}
        if (joinwait == -1) {
          t.join();
        } else {
          t.join(joinwait);
        }
{code}

We don't need to use -1 as a special value, as join already has a special value of 0:

>From Thread.join() javadoc:
"Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-1405) Threads.shutdown has unnecessary branch

Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nitay Joffe updated HBASE-1405:
-------------------------------

    Status: Patch Available  (was: Open)

> Threads.shutdown has unnecessary branch
> ---------------------------------------
>
>                 Key: HBASE-1405
>                 URL: https://issues.apache.org/jira/browse/HBASE-1405
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: hbase-1405.patch
>
>
> {code}
>         if (joinwait == -1) {
>           t.join();
>         } else {
>           t.join(joinwait);
>         }
> {code}
> We don't need to use -1 as a special value, as join already has a special value of 0:
> From Thread.join() javadoc:
> "Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (HBASE-1405) Threads.shutdown has unnecessary branch

Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nitay Joffe reassigned HBASE-1405:
----------------------------------

    Assignee: Nitay Joffe

> Threads.shutdown has unnecessary branch
> ---------------------------------------
>
>                 Key: HBASE-1405
>                 URL: https://issues.apache.org/jira/browse/HBASE-1405
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> {code}
>         if (joinwait == -1) {
>           t.join();
>         } else {
>           t.join(joinwait);
>         }
> {code}
> We don't need to use -1 as a special value, as join already has a special value of 0:
> From Thread.join() javadoc:
> "Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-1405) Threads.shutdown has unnecessary branch

Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nitay Joffe updated HBASE-1405:
-------------------------------

    Attachment: hbase-1405.patch

> Threads.shutdown has unnecessary branch
> ---------------------------------------
>
>                 Key: HBASE-1405
>                 URL: https://issues.apache.org/jira/browse/HBASE-1405
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: hbase-1405.patch
>
>
> {code}
>         if (joinwait == -1) {
>           t.join();
>         } else {
>           t.join(joinwait);
>         }
> {code}
> We don't need to use -1 as a special value, as join already has a special value of 0:
> From Thread.join() javadoc:
> "Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-1405) Threads.shutdown has unnecessary branch

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1405:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks for patch Nitay.

> Threads.shutdown has unnecessary branch
> ---------------------------------------
>
>                 Key: HBASE-1405
>                 URL: https://issues.apache.org/jira/browse/HBASE-1405
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: hbase-1405.patch
>
>
> {code}
>         if (joinwait == -1) {
>           t.join();
>         } else {
>           t.join(joinwait);
>         }
> {code}
> We don't need to use -1 as a special value, as join already has a special value of 0:
> From Thread.join() javadoc:
> "Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.