[GitHub] [kyuubi] turboFei commented on a diff in pull request #3739: [REST] Remove unused parameters in SessionOpenRequest

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #3739:
URL: https://github.com/apache/kyuubi/pull/3739#discussion_r1065640718


##########
docs/deployment/migration-guide.md:
##########
@@ -24,6 +24,7 @@
 * Since Kyuubi 1.7, Kyuubi returns engine's information for `GetInfo` request instead of server. To restore the previous behavior, set `kyuubi.server.info.provider` to `SERVER`.
 * Since Kyuubi 1.7, Kyuubi session type `SQL` is refactored to `INTERACTIVE`, because Kyuubi supports not only `SQL` session, but also `SCALA` and `PYTHON` sessions.
   User need to use `INTERACTIVE` sessionType to look up the session event.
+* Since Kyuubi 1.7, the REST API of `Open(create) a session` will not contains parameters `user` `password` and `IpAddr`. We should set user and password in `Authorization` of http request when needed.

Review Comment:
   nit: 
   
   ```
   User and password should be set in `Authorization` of http request if needed.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org