You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2010/02/03 13:29:28 UTC
[jira] Created: (SOLR-1750) SystemStatsRequestHandler - replacement
for stats.jsp
SystemStatsRequestHandler - replacement for stats.jsp
-----------------------------------------------------
Key: SOLR-1750
URL: https://issues.apache.org/jira/browse/SOLR-1750
Project: Solr
Issue Type: Improvement
Components: web gui
Reporter: Erik Hatcher
Assignee: Erik Hatcher
Priority: Trivial
Fix For: 1.5
Attachments: SystemStatsRequestHandler.java
stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
Here's a request handler that emits everything stats.jsp does.
For now, it needs to be registered in solrconfig.xml like this:
{code}
<requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
{code}
But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839928#action_12839928 ]
Hoss Man commented on SOLR-1750:
--------------------------------
Committed revision 917812.
I went ahead and commited the most recent attachment under the name "SystemInfoRequestHandler" with slightly generalized javadocs.
Leaving the issue open so we make sure to settle the remaining issues before we release...
* decide if we want to change the name
* add default registration as part of the AdminRequestHandler (ie: /admin/info ?)
* add some docs (didn't wnat to make a wiki page until we're certain of hte name)
* decide if we want to modify the response structure (should all of the top level info be encapsulated in a container?)
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java, SystemStatsRequestHandler.java, SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829052#action_12829052 ]
Erik Hatcher commented on SOLR-1750:
------------------------------------
Also, food for thought, when (hopefully not if) the VelocityResponseWriter is moved into core, we can deprecate stats.jsp and skin the output of this request handler for a similar pleasant view like stats.jsp+client-side xsl does now.
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829199#action_12829199 ]
Steven Rowe commented on SOLR-1750:
-----------------------------------
bq. "stats" is a bit overloaded (StatsComponent). as is "system" (SystemInfoHandler).
I swear when I read this, before I suggested SIRH, you had written "SystemStatsHandler" instead of "SystemInfoHandler". Not sure how you changed it without a red "edited" annotation in the header for your comment.... Et tu, Atlassian?
Anyway, pathological paranoia aside, SIRH is too close to SystemInfoHandler - I hereby begin the process of formally withdrawing it from consideration. Ok, done.
stats.xsl creates a title prefix "Solr Statistics" - how about SolrStatsRequestHandler?
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1750) SystemInfoRequestHandler - replacement
for stats.jsp and registry.jsp
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1750:
---------------------------
Summary: SystemInfoRequestHandler - replacement for stats.jsp and registry.jsp (was: SystemStatsRequestHandler - replacement for stats.jsp)
> SystemInfoRequestHandler - replacement for stats.jsp and registry.jsp
> ---------------------------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java, SystemStatsRequestHandler.java, SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829050#action_12829050 ]
Erik Hatcher commented on SOLR-1750:
------------------------------------
I'll commit this in the near future.
Any thoughts on the naming of this beast? "stats" is a bit overloaded (StatsComponent). as is "system" (SystemInfoHandler).
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829773#action_12829773 ]
Hoss Man commented on SOLR-1750:
--------------------------------
bq. Any thoughts on the naming of this beast?
SystemInfoHandler sounds good.
This would probably also be a good time to retire "registry.jsp" ... all we need to do is add a few more pieces of "system info" to this handler (and add some param options to disable the "stats" part of the output)
bq. Also, food for thought, when (hopefully not if) the VelocityResponseWriter is moved into core, we can deprecate stats.jsp and skin the output of this request handler for a similar pleasant view like stats.jsp+client-side xsl does now.
Even if/when VelocityResponseWRiter is in the core, i'd still rather just rely on client side XSLT for this to reduce the number of things that could potentially get missconfigured and then confuse people why the page doesn't look right ... the XmlResponseWRriter has always supported a "stylesheet" param that (while not generally useful to most people) let's you easily reference any style sheet that can be served out of the admin directory ... all we really need is an updatd .xsl file to translate the standard XML format into the old style stats view.
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1750) SystemStatsRequestHandler - replacement
for stats.jsp
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1750:
---------------------------
Attachment: SystemStatsRequestHandler.java
Some updates to Erik's previous version...
# adds everything from registry.jsp
#* lucene/solr version info
#* source/docs info for each object
# forcibly disable HTTP Caching
# adds params to control which objects are listed
#* (multivalued) "cat" param restricts category names (default is all)
#* (multivalued) "key" param restricts object keys (default is all)
# adds (boolean) "stats" param to control if stats are outputed for each object
#* per-field style override can be used to override per object key
# refactored the old nested looping that stast.jsp did over every object and every category into a single pass
# switch all HashMaps to NamedLists or SimpleOrderedMaps to preserve predictable ordering
Examples...
* {{?cat=CACHE}}
** return info about caches, but nothing else (stats disabled by default)
* {{?stats=true&cat=CACHE}}
** return info and stats about caches, but nothing else
* {{?stats=true&f.fieldCache.stats=false}}
** Info about everything, stats for everything except fieldCache
* {{?key=fieldCache&stats=true}}
** Return info and stats for fieldCache, but nothing else
I left the class name alone, but i vote for "SystemInfoRequestHandler" with a default registration of "/admin/info"
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java, SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1750) SystemStatsRequestHandler - replacement
for stats.jsp
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1750:
---------------------------
Attachment: SystemStatsRequestHandler.java
Whoops .. i botched the HTTP Caching prevention in the last version
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java, SystemStatsRequestHandler.java, SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemInfoRequestHandler -
replacement for stats.jsp and registry.jsp
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840208#action_12840208 ]
Erik Hatcher commented on SOLR-1750:
------------------------------------
Thanks Hoss for committing!
naming: I'm fine with how it is, but fine if the name changes too and +1 to adding default registration
> SystemInfoRequestHandler - replacement for stats.jsp and registry.jsp
> ---------------------------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java, SystemStatsRequestHandler.java, SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829144#action_12829144 ]
Steven Rowe commented on SOLR-1750:
-----------------------------------
bq. Any thoughts on the naming of this beast?
How about SysInfoRequestHandler - bonus: SIRH evokes [RFK's assassin|http://en.wikipedia.org/wiki/Sirhan_Sirhan]
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1750) SystemStatsRequestHandler - replacement
for stats.jsp
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-1750:
-------------------------------
Attachment: SystemStatsRequestHandler.java
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1750) SystemStatsRequestHandler -
replacement for stats.jsp
Posted by "Simon Rosenthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829354#action_12829354 ]
Simon Rosenthal commented on SOLR-1750:
---------------------------------------
+1 on SolrStatsRequestHandler
You might want to consider either omitting or making optional the Lucene Fieldcache stats; they can often be *very* slow to be generated ( see http://www.lucidimagination.com/search/document/5ba908577d2e4c25/stats_page_slow_in_latest_nightly#2f40166c25f9bfa0 ). One use case for this request handler that I can see is high frequency (every few seconds) monitoring as part of performance testing, for which a fast response is pretty mandatory.
> SystemStatsRequestHandler - replacement for stats.jsp
> -----------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats" class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.