You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/02 05:25:01 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #2297: HDDS-5286. Document SCM HA classes
sky76093016 opened a new pull request #2297:
URL: https://github.com/apache/ozone/pull/2297
## What changes were proposed in this pull request?
Add class-level javadoc for SCMDBCheckpointProvider and SCMHANodeDetails.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5286
## How was this patch tested?
No test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644408521
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHANodeDetails.java
##########
@@ -60,6 +60,9 @@
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SECURITY_SERVICE_PORT_KEY;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
+/**
+ * Construct SCM HA node details.
Review comment:
For class doc, can we remove "Construct"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao merged pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #2297:
URL: https://github.com/apache/ozone/pull/2297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644417592
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMDBCheckpointProvider.java
##########
@@ -31,6 +31,10 @@
// TODO: define a generic interface for this
+
+/**
+ * Checkpoint write sream and exception handling.
Review comment:
Solve it.
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHANodeDetails.java
##########
@@ -60,6 +60,9 @@
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SECURITY_SERVICE_PORT_KEY;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
+/**
+ * Construct SCM HA node details.
Review comment:
Solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644408338
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMDBCheckpointProvider.java
##########
@@ -31,6 +31,10 @@
// TODO: define a generic interface for this
+
+/**
+ * Checkpoint write sream and exception handling.
Review comment:
sream=> stream?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644417592
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMDBCheckpointProvider.java
##########
@@ -31,6 +31,10 @@
// TODO: define a generic interface for this
+
+/**
+ * Checkpoint write sream and exception handling.
Review comment:
Solve it.
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHANodeDetails.java
##########
@@ -60,6 +60,9 @@
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SECURITY_SERVICE_PORT_KEY;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
+/**
+ * Construct SCM HA node details.
Review comment:
Solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#issuecomment-854063607
LGTM, +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#issuecomment-854063607
LGTM, +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao merged pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #2297:
URL: https://github.com/apache/ozone/pull/2297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644408338
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMDBCheckpointProvider.java
##########
@@ -31,6 +31,10 @@
// TODO: define a generic interface for this
+
+/**
+ * Checkpoint write sream and exception handling.
Review comment:
sream=> stream?
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHANodeDetails.java
##########
@@ -60,6 +60,9 @@
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SECURITY_SERVICE_PORT_KEY;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
+/**
+ * Construct SCM HA node details.
Review comment:
For class doc, can we remove "Construct"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org