You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2009/06/02 07:22:07 UTC
[jira] Created: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
-----------------------------------------------------------------------------------
Key: HIVE-528
URL: https://issues.apache.org/jira/browse/HIVE-528
Project: Hadoop Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.4.0
Reporter: Namit Jain
Assignee: Namit Jain
split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716803#action_12716803 ]
Zheng Shao commented on HIVE-528:
---------------------------------
+1. Will commit if the test passes.
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch, hive.528.2.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-528:
----------------------------
Attachment: hive.528.2.patch
incorporated Zheng's comments.
MapJoinOperator is a singleton - if the joins do not merge, there is a FileSink after the first MapJoin
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch, hive.528.2.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-528:
----------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
Release Note: HIVE-528. Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue. (Namit Jain via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.4.0
>
> Attachments: hive.528.1.patch, hive.528.2.patch, hive.528.3.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-528:
----------------------------
Status: Patch Available (was: Open)
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-528:
----------------------------
Attachment: hive.528.1.patch
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716778#action_12716778 ]
Zheng Shao commented on HIVE-528:
---------------------------------
Nitpick:
{code}
+ MapJoinObjectCtx ctx = MapJoinOperator.getMapMetadata().get(new Integer(metadataTag));
{code}
Use Integer.valueOf() instead since this is going to be called multiple times with the same integer number.
Also just to make sure, MapJoinOperator is a singleton so that getMapMetadata() can be defined as a static function?
is it possible to have 2 MapJoinOperator in the same mapper? (let's assume their join keys are different so they cannot be merged)
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-528) Map Join followup: split MapJoinObject
into MapJoinObjectKey and MapJoinObjectValue
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-528:
----------------------------
Attachment: hive.528.3.patch
Talked offline with Zheng who told a minor performance problem. Fixed that.
> Map Join followup: split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
> Key: HIVE-528
> URL: https://issues.apache.org/jira/browse/HIVE-528
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.528.1.patch, hive.528.2.patch, hive.528.3.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code cleanup
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.