You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2013/04/10 20:24:16 UTC
[jira] [Commented] (SLING-2701) SlingAuthenticator is volatile to
multithreaded auth path updates.
[ https://issues.apache.org/jira/browse/SLING-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628067#comment-13628067 ]
Carsten Ziegeler commented on SLING-2701:
-----------------------------------------
I'm not 100% sure but I think your patch is syncing too much and reading the current code, I think it does the right syncing. However, I recently found a bug in some other place (SLING-2812). Maybe your problem is related to that?
Or can you further explain, why a larger sync block is needed?
Thanks
> SlingAuthenticator is volatile to multithreaded auth path updates.
> ------------------------------------------------------------------
>
> Key: SLING-2701
> URL: https://issues.apache.org/jira/browse/SLING-2701
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Environment: CQ 5.4
> Reporter: Dominik Smogór
> Assignee: Carsten Ziegeler
> Attachments: authcore-SLING-2701.patch
>
>
> SlingAuthenticator has a registered listener on services that share sling.auth.requirements service attributes.
> These paths serve as basis to PathBasedHolders that decide what request paths need to be authenticated.
> When the listener is called from multiple threads on the same service SlingAuthenticator PathBasedHolders cache gets corrupted due to insufficient synchronization. The effect is artificial multiplication of records.
> This patch adds synchronized block within the listener.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira