You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/30 04:08:36 UTC

[GitHub] [arrow] liyafan82 opened a new pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

liyafan82 opened a new pull request #8801:
URL: https://github.com/apache/arrow/pull/8801


   This PR fixes a problem reported by the user. 
   See the description in https://issues.apache.org/jira/browse/ARROW-10748


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield closed pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #8801:
URL: https://github.com/apache/arrow/pull/8801


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8801:
URL: https://github.com/apache/arrow/pull/8801#issuecomment-739683563


   +1 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on a change in pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #8801:
URL: https://github.com/apache/arrow/pull/8801#discussion_r537247275



##########
File path: java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
##########
@@ -92,6 +103,39 @@ public void testJdbcToArrowValuesNoLimit() throws SQLException, IOException {
     validate(iterator);
   }
 
+  @Test
+  public void testTimeStampConsumer() throws SQLException, IOException {

Review comment:
       nit: Timestamp?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8801:
URL: https://github.com/apache/arrow/pull/8801#issuecomment-735538025


   https://issues.apache.org/jira/browse/ARROW-10748


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on a change in pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #8801:
URL: https://github.com/apache/arrow/pull/8801#discussion_r537247686



##########
File path: java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
##########
@@ -92,6 +103,39 @@ public void testJdbcToArrowValuesNoLimit() throws SQLException, IOException {
     validate(iterator);
   }
 
+  @Test
+  public void testTimeStampConsumer() throws SQLException, IOException {

Review comment:
       oh I see arrow's Vectors are inconsistent here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #8801: ARROW-10748: [Java][JDBC] Support consuming timestamp data when time zone is not available

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #8801:
URL: https://github.com/apache/arrow/pull/8801#issuecomment-739733956


   @emkornfield Thanks for your comments. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org