You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Diluka Moratuwage (JIRA)" <ji...@apache.org> on 2008/06/30 14:27:45 UTC
[jira] Created: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
-----------------------------------------------
Key: AXIS2C-1211
URL: https://issues.apache.org/jira/browse/AXIS2C-1211
Project: Axis2-C
Issue Type: Bug
Environment: Ubuntu 7.04
Reporter: Diluka Moratuwage
I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Resolved: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Posted by "Damitha Kumarage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Damitha Kumarage resolved AXIS2C-1211.
--------------------------------------
Resolution: Fixed
Diluka,
I applied the patch and it seems ok. Thanks for the patch.
> Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
> -----------------------------------------------
>
> Key: AXIS2C-1211
> URL: https://issues.apache.org/jira/browse/AXIS2C-1211
> Project: Axis2-C
> Issue Type: Bug
> Environment: Ubuntu 7.04
> Reporter: Diluka Moratuwage
> Attachments: conf_ctx.patch
>
>
> I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
> So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609511#action_12609511 ]
Supun Kamburugamuva commented on AXIS2C-1211:
---------------------------------------------
Hi Diluka,
I think the patch you provided is for savan/c not Axis2/C -).
Supun..
> Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
> -----------------------------------------------
>
> Key: AXIS2C-1211
> URL: https://issues.apache.org/jira/browse/AXIS2C-1211
> Project: Axis2-C
> Issue Type: Bug
> Environment: Ubuntu 7.04
> Reporter: Diluka Moratuwage
> Attachments: conf_ctx.patch
>
>
> I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
> So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Updated: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Posted by "Diluka Moratuwage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diluka Moratuwage updated AXIS2C-1211:
--------------------------------------
Attachment: conf_ctx.patch
This patch removes all unnecessary use of conf_ctx within savan module services.
> Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
> -----------------------------------------------
>
> Key: AXIS2C-1211
> URL: https://issues.apache.org/jira/browse/AXIS2C-1211
> Project: Axis2-C
> Issue Type: Bug
> Environment: Ubuntu 7.04
> Reporter: Diluka Moratuwage
> Attachments: conf_ctx.patch
>
>
> I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
> So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Posted by "Diluka Moratuwage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609507#action_12609507 ]
Diluka Moratuwage commented on AXIS2C-1211:
-------------------------------------------
Yes that is true, even though we create conf_ctx within subs_mgr and publisher services, it's not actually needed. I have attached a patch which removes all unnecessary usages of conf_ctx, and modified the publishing client, so that it no longer has a conf_ctx within that.
> Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
> -----------------------------------------------
>
> Key: AXIS2C-1211
> URL: https://issues.apache.org/jira/browse/AXIS2C-1211
> Project: Axis2-C
> Issue Type: Bug
> Environment: Ubuntu 7.04
> Reporter: Diluka Moratuwage
>
> I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
> So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-1211) Improving the
AXIS2_SVC_SKELETON_INIT_WITH_CONF
Posted by "Damitha Kumarage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609260#action_12609260 ]
Damitha Kumarage commented on AXIS2C-1211:
------------------------------------------
Diluka,
Can you show me a specific situation where conf_ctx needed in service initialization. In Savan/C
I can see that in publishing client sample and subscription manager service a conf_ctx is created
out of conf passed to init function. But even there it is not neccessary to create such a cont_ctx
because it is not used for any useful things. It is created just because publishing cliet needs it.
But when you look at publising client code it does not use it either. It jusr retrieve conf from it.
It is the only use publishing client has from conf_ctx. So my suggestion is to pass just the
conf to the service init as it is now. But in Savan/C we need to change publishing client code
not to accept a conf_ctx but a conf.
> Improving the AXIS2_SVC_SKELETON_INIT_WITH_CONF
> -----------------------------------------------
>
> Key: AXIS2C-1211
> URL: https://issues.apache.org/jira/browse/AXIS2C-1211
> Project: Axis2-C
> Issue Type: Bug
> Environment: Ubuntu 7.04
> Reporter: Diluka Moratuwage
>
> I have some problem with AXIS2_SVC_SKELETON_INIT_WITH_CONF macro. Apparently it allows the service to use the configuration, within the service, when it's starting up. But, by the time this function is called (when loading services), we have already created the conf_ctx. And as I have seen the very usage of this comes when a service have to be started up. But in order to use it, we have to create conf_ctx within the service most probably.
> So I think it will be appropriate to send the conf_ctx instead of conf into a service. So if the service has any need of the conf, still it can get the conf from the conf_ctx.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org