You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/16 23:51:59 UTC

[GitHub] [kafka] hachikuji opened a new pull request #9762: KAFKA-10861; Fix race condition in flaky test `testFencingOnSendOffsets`

hachikuji opened a new pull request #9762:
URL: https://github.com/apache/kafka/pull/9762


   I wasn't able to reproduce the failure locally, but it looks like there is a race condition with the sending of the records in the first producer. The test case assumes that these records have been completed before the call to `sendOffsetsToTransaction`, but they very well might not be. It is even possible for the writes from the second producer to arrive first which would then result in the test failure that we are seeing. The solution is to force the send with `flush()`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #9762: KAFKA-10861; Fix race condition in flaky test `testFencingOnSendOffsets`

Posted by GitBox <gi...@apache.org>.

hachikuji merged pull request #9762:
URL: https://github.com/apache/kafka/pull/9762


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9762: KAFKA-10861; Fix race condition in flaky test `testFencingOnSendOffsets`

Posted by GitBox <gi...@apache.org>.

guozhangwang commented on pull request #9762:
URL: https://github.com/apache/kafka/pull/9762#issuecomment-747137717


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org