[GitHub] [comdev-site] clr-apache commented on a change in pull request #41: Update newcommitter.md

[GitBox <gi...@apache.org>]

clr-apache commented on a change in pull request #41:
URL: https://github.com/apache/comdev-site/pull/41#discussion_r650445718



##########
File path: source/newcommitter.md
##########
@@ -95,12 +95,12 @@ If they accept, then do:
 <a name="NewCommitter-Discussion"></a>
 ### Discussion
 
-We do the vote on the private mailing list to enable a frank discussion.
+We do the vote on the `private@` mailing list to enable a frank discussion.

Review comment:
       If you want to make it clear what the mail list is called, perhaps private@ is a better term than @private. 

##########
File path: source/newcommitter.md
##########
@@ -295,11 +295,11 @@ This is the followup email after the new committer has accepted the invitation
 
     Just as before you became a committer, participation in any ASF community
     requires adherence to the ASF Code of Conduct:
-      https://www.apache.org/foundation/policies/conduct.html
+      https://www.apache.org/foundation/policies/conduct.html.
     
     [PROJECT should insert its own guidelines here; if none are available,
-     the Apache Forrest guidelines are available as a template.]
-      https://forrest.apache.org/guidelines.html
+     the Apache Forrest guidelines are available as a template.
+      https://forrest.apache.org/guidelines.html.]

Review comment:
       Forrest is now in the attic and might not be a great example any more...

##########
File path: source/newcommitter.md
##########
@@ -110,40 +110,40 @@ becomes obvious that we should invite them. This encourages them and keeps
 them enthusiastic. If we leave it too long, then we risk them becoming
 disillusioned.
 
-On the PMC list we can each say exactly what we feel about each person,
+On the `@private` list we can each say exactly what we feel about each person,
 with no holds barred. Keep the discussion concise. The praise part can
 be done later in public. Keep in mind, however, that if the member becomes
 a PMC member later, they will have access to this discussion.
 
 Let the Vote thread run for one week.
 
-A positive result is achieved by **Consensus Approval**: i.e. at least 3 +1
+A positive result is achieved by **Consensus Approval**: at least 3 +1
 votes and no vetoes.
 
 Any veto must be accompanied by reasoning and the vetoer must be prepared to defend it.
-Other members can attempt to encourage them to change their minds.
+Other members can attempt to encourage them to change their mind.
 
 New committers can be either quiet or active as they choose. If we find
-that certain people lapse and don't ever contribute, then each project can take steps
+that certain people lapse and don't ever contribute, then the project can take steps
 to retire them.
 
 After a positive result, record the result on the PMC list with a [RESULT][VOTE] subject
 and then invite the candidate. We give candidates a chance to decline committership in private. They
 can post a reply to the PMC mailing list.
 
-After we reach a decision on the PMC list, and after the steps above, we
-will announce it on the dev list. We can then each follow up with
+After we reach a decision on the `@private` list, and after the steps above, we

Review comment:
       private@

##########
File path: source/newcommitter.md
##########
@@ -295,11 +295,11 @@ This is the followup email after the new committer has accepted the invitation
 
     Just as before you became a committer, participation in any ASF community
     requires adherence to the ASF Code of Conduct:
-      https://www.apache.org/foundation/policies/conduct.html
+      https://www.apache.org/foundation/policies/conduct.html.

Review comment:
       The trailing . might make it hard to simply click on the link unless there is some metadata around it.

##########
File path: source/newcommitter.md
##########
@@ -110,40 +110,40 @@ becomes obvious that we should invite them. This encourages them and keeps
 them enthusiastic. If we leave it too long, then we risk them becoming
 disillusioned.
 
-On the PMC list we can each say exactly what we feel about each person,
+On the `@private` list we can each say exactly what we feel about each person,

Review comment:
       private@

##########
File path: source/newcommitter.md
##########
@@ -29,63 +29,63 @@ The following are some points to consider when assessing a candidate's qualifica
 ### Ability to work cooperatively with peers. 
 How do we evaluate?
 
-  - By the interactions they have through mail.
+  - By the interactions they have through email.
   - By how they respond to criticism.
   - By how they participate in the group decision-making process.
 
 <a name="NewCommitter-Abilitytobeamentor."></a>
 ### Ability to be a mentor.
 How do we evaluate?
 
-  - By the interactions they have through mail.
-  - By how clear they are and how willing they are to point at appropriate background
-materials (or even create them).
+  - By the interactions they have through email.
+  - By how clear they are and how willing they are to identify or even create appropriate background
+materials.
 
 <a name="NewCommitter-Community"></a>
 ### Community
 How do we evaluate?
 
-  - By the interactions they have through mail.
+  - By the interactions they have through email.
   - Do they help to answer questions raised on the mailing list; do they show a helpful 
 attitude and respect for other people's ideas?
 
 <a name="NewCommitter-Committment"></a>
 ### Commitment
 How do we evaluate?
 
-  - By time given to the project already
-  - By sticking through tough issues
-  - By helping on not-so-fun tasks as well
+  - By time already given to the project.
+  - By how well they stick with the process through tough issues.
+  - By how they help on not-so-fun tasks.
 
 <a name="NewCommitter-Personalskill/ability"></a>
 ### Personal skill/ability
 How do we evaluate?
 
   - A solid general understanding of the project. 
-  - Quality of discussion in mail.
-  - Patches (where applicable) easy to apply with only a cursory review.
+  - Quality of discussion in email.
+  - Whether their patches (where applicable) are easy to apply with only a cursory review.
 
 <a name="NewCommitter-NewCommitterProcess"></a>
 ## New Committer Process
 
 This section describes a typical Apache project's process for handling the
-vote to add a new committer. Templates mentioned in the process appear at
+vote to add a new committer. Templates mentioned in the process appear
 later in this document.
 
 <a name="NewCommitter-Summary"></a>
 ### Summary
 
 1. Call a vote (templates/committerVote.txt)
 1. Close the vote
-1. Invite the new committer (templates/committerInvite.txt)
+1. If the result is positive, invite the new committer (templates/committerInvite.txt)
 
-If they accept, then do:
+If they accept, then:
 
 1. Accept the committer (templates/committerAccept.txt)
 1. Wait until we see that receipt of CLA is recorded
 1. Request creation of the committer account (template/committerCreate.txt)
-   1. now wait until root says it is done
-   1. PMC Chair to enable svn and other access
+   1. Wait until root says it is done

Review comment:
       I have additional edits to the onboarding process that will wait until this PR is accepted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org