You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/27 06:27:25 UTC
[GitHub] [kylin] shaofengshi opened a new pull request #1124: KYLIN-4388
Refine the Dockerfile
shaofengshi opened a new pull request #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124
see https://issues.apache.org/jira/browse/KYLIN-4388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #1124: KYLIN-4388 Refine the
Dockerfile
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-592390198
@weibin0516 good suggestion; I'm doing that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] weibin0516 commented on issue #1124: KYLIN-4388 Refine the
Dockerfile
Posted by GitBox <gi...@apache.org>.
weibin0516 commented on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-592253825
A small suggestion: Can you explain in the readme how to copy the locally compiled kylin installation package to a container for quick verification?
I think this is useful for developers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1124: KYLIN-4388 Refine the
Dockerfile
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-591832630
## Pull Request Test Coverage Report for [Build 5664](https://coveralls.io/builds/28991826)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.005%**) to **27.534%**
---
| Totals | [](https://coveralls.io/builds/28991826) |
| :-- | --: |
| Change from base [Build 5663](https://coveralls.io/builds/28990866): | 0.005% |
| Covered Lines: | 24300 |
| Relevant Lines: | 88254 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] weibin0516 commented on issue #1124: KYLIN-4388 Refine the
Dockerfile
Posted by GitBox <gi...@apache.org>.
weibin0516 commented on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-592252953
LGTM, really good job !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1124: KYLIN-4388 Refine the
Dockerfile
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-592411947
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=h1) Report
> Merging [#1124](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ece4d2e8bb93c18a6805f269dbc5e14623e572b0?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1124 +/- ##
============================================
+ Coverage 25% 25.06% +0.06%
- Complexity 6227 6247 +20
============================================
Files 1443 1445 +2
Lines 88142 88262 +120
Branches 12337 12348 +11
============================================
+ Hits 22037 22122 +85
- Misses 63937 63969 +32
- Partials 2168 2171 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `6.64% <0%> (-0.06%)` | `4% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <0%> (-0.06%)` | `44% <0%> (ø)` | |
| [...he/kylin/tool/metrics/systemcube/ModelCreator.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9tZXRyaWNzL3N5c3RlbWN1YmUvTW9kZWxDcmVhdG9yLmphdmE=) | `93.05% <0%> (ø)` | `19% <0%> (ø)` | :arrow_down: |
| [...lin/tool/metrics/systemcube/KylinTableCreator.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9tZXRyaWNzL3N5c3RlbWN1YmUvS3lsaW5UYWJsZUNyZWF0b3IuamF2YQ==) | `79.59% <0%> (ø)` | `7% <0%> (ø)` | :arrow_down: |
| [...pache/kylin/metrics/lib/impl/InstantReservoir.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL0luc3RhbnRSZXNlcnZvaXIuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...pache/kylin/metrics/lib/impl/TimePropertyEnum.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1RpbWVQcm9wZXJ0eUVudW0uamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/kylin/metrics/lib/impl/RecordEvent.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1JlY29yZEV2ZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../kylin/metrics/lib/impl/RecordEventTimeDetail.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1JlY29yZEV2ZW50VGltZURldGFpbC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/kylin/job/metrics/JobMetricsFacade.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9tZXRyaWNzL0pvYk1ldHJpY3NGYWNhZGUuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...s/lib/impl/kafka/KafkaActiveReserviorListener.java](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0cmljcy9saWIvaW1wbC9rYWZrYS9LYWZrYUFjdGl2ZVJlc2Vydmlvckxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/kylin/pull/1124/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=footer). Last update [ece4d2e...13804b8](https://codecov.io/gh/apache/kylin/pull/1124?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #1124: KYLIN-4388 Refine
the Dockerfile
Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1124: KYLIN-4388
Refine the Dockerfile
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1124: KYLIN-4388 Refine the Dockerfile
URL: https://github.com/apache/kylin/pull/1124#issuecomment-591832630
## Pull Request Test Coverage Report for [Build 5667](https://coveralls.io/builds/29020145)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **137** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.002%**) to **27.527%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29020145/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [stream-receiver/src/main/java/org/apache/kylin/stream/server/StreamingServer.java](https://coveralls.io/builds/29020145/source?filename=stream-receiver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fserver%2FStreamingServer.java#L165) | 135 | 0% |
<!-- | **Total:** | **137** | | -->
| Totals | [](https://coveralls.io/builds/29020145) |
| :-- | --: |
| Change from base [Build 5663](https://coveralls.io/builds/28990866): | -0.002% |
| Covered Lines: | 24296 |
| Relevant Lines: | 88262 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services