[GitHub] [flink] zhuzhurk opened a new pull request #9675: [FLINK-13953] [runtime] Facilitate enabling new scheduler in MiniCluster Tests

[GitBox <gi...@apache.org>]

zhuzhurk opened a new pull request #9675: [FLINK-13953] [runtime] Facilitate enabling new scheduler in MiniCluster Tests
URL: https://github.com/apache/flink/pull/9675
 
 
   ## What is the purpose of the change
   
   Currently, tests using the {{MiniCluster}} use the legacy scheduler by default. Once the new scheduler is implemented, we should run tests with the new scheduler enabled. However, it is not expected that all tests will pass immediately. Therefore, it should be possible to enable the new scheduler for a subset of tests. 
   
   In the first step the tests should be able to run manually against new scheduler.
   
   *Acceptance Criteria*
    * A junit test category {{AlsoRunWithSchedulerNG}} can be used to mark MiniCluster tests.
    * A new maven profile {{scheduler-ng}} will be enabled to support running {{AlsoRunWithSchedulerNG}} annotated tests with the new scheduler.
   
   ## Brief change log
   
   The change is inspired by the prototype from @tillrohrmann at https://github.com/tillrohrmann/flink/commit/dee9e7d82f65fa1697489de743e84dcf02d76711.
     - *Added a category marker for new scheduler testing*
     - *Enabled setting scheduler type in MiniClusterConfiguration via environment variable*
     - *Added a maven profile to run annotated MiniCluster tests for the new scheduler*
     - *other hotfixes, details see each hotfix commit*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added UTs for MiniClusterConfiguration changes*
     - *Manually verified the change by running command "mvn verify -Dscheduler-ng". Verified that only the tests annotated with `AlsoRunWithSchedulerNG` are executed in this way. Verified that the scheduler type can be specified by setting maven profiles or properties.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services