You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/01/24 11:36:36 UTC

[GitHub] [james-project] chibenwa edited a comment on pull request #851: JAMES-3683 Implement PerSenderRateLimit mailet

chibenwa edited a comment on pull request #851:
URL: https://github.com/apache/james-project/pull/851#issuecomment-1019999304


   > I think I might find a bug here. I think we should not increase the counter when it exceeds one of the rate limits. Please have a look at the test below:
   
   I think this is more part of the underlying `RateLimiter` component and we *might* be limited on this by the `RateLimitJ` choice.
   
   Could you be having a look, @quantranhong1999 ?
   
   (If you are right, this IMO do not impact much rate limiting use cases but definitely jeopardizes throttling use cases)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org