You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by demiankatz <gi...@git.apache.org> on 2016/01/14 18:43:12 UTC

[GitHub] lucene-solr pull request: Resolution for SOLR-2798 (add support fo...

GitHub user demiankatz opened a pull request:

    https://github.com/apache/lucene-solr/pull/216

    Resolution for SOLR-2798 (add support for multi-valued localParams)

    Previous to this fix, when using localParams syntax, a repeated parameter would be handled with a "last value wins" policy. This PR changes the behavior to allow all values of the parameter to be accepted, which seems like it should be the expected behavior, since many Solr parameters are intended to be repeatable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/demiankatz/lucene-solr solr-2798-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit b991e72b04a4de4c35f4fa1dc1338eafb67756d8
Author: Demian Katz <de...@villanova.edu>
Date:   2016-01-13T19:43:13Z

    Allow parseLocalParams to target a ModifiableSolrParams object.
    - Progress on SOLR-2798.

commit 314a58c593de4cf7ed80bffc7b3e8034d17143be
Author: Demian Katz <de...@villanova.edu>
Date:   2016-01-13T20:06:37Z

    Switch calls to parseLocalParams to use ModifiableSolrParams instead of Map.
    - See SOLR-2798.

commit 107f6224aa33edea08a961adcb2e57b2cc96e69e
Author: Demian Katz <de...@villanova.edu>
Date:   2016-01-14T14:12:27Z

    Deprecated obsolete methods; added comments.

commit ed544b6d726e4e79319cfb5808cc3fdfde6e0f26
Author: Demian Katz <de...@villanova.edu>
Date:   2016-01-14T14:51:24Z

    Added higher-level test for localParams fix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request #216: Upgrade master to 8 for the 7.0 release

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucene-solr/pull/216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org