[GitHub] [camel] orpiske commented on a diff in pull request #8883: camel-kafka: prevent exceptions in close from leaking (CAMEL-18796)

[GitBox <gi...@apache.org>]

orpiske commented on code in PR #8883:
URL: https://github.com/apache/camel/pull/8883#discussion_r1045919183


##########
components/camel-kafka/src/main/java/org/apache/camel/processor/resume/kafka/SingleNodeKafkaResumeStrategy.java:
##########
@@ -396,6 +400,8 @@ public void stop() {
             IOHelper.close(producer, "Kafka producer", LOG);
         } catch (InterruptedException e) {
             Thread.currentThread().interrupt();
+        } catch (Exception e) {
+            LOG.error("Error closing the Kafka producer: {} (this error will be ignored)", e.getMessage(), e);

Review Comment:
   Ah, definitely it should! Thanks for pointing it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org