[jira] [Commented] (PHOENIX-4854) Make LoggingPhoenixResultSet idempotent when logging metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586244#comment-16586244 ] 

ASF GitHub Bot commented on PHOENIX-4854:
-----------------------------------------

GitHub user karanmehta93 opened a pull request:

    https://github.com/apache/phoenix/pull/332

    PHOENIX-4854 Make LoggingPhoenixResultSet idempotent when logging met…

    …rics
    
    @twdsilva Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/332.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #332
    
----
commit 03308c779c78bcefda561f3d37d6e912b2f975c3
Author: Karan Mehta <ka...@...>
Date:   2018-08-20T17:12:37Z

    PHOENIX-4854 Make LoggingPhoenixResultSet idempotent when logging metrics

----


> Make LoggingPhoenixResultSet idempotent when logging metrics
> ------------------------------------------------------------
>
>                 Key: PHOENIX-4854
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4854
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Major
>
> ResultSet close method can be called multiple times and LoggingResultSet object tries to call PhoenixMetricsLog methods every single time. These per query metrics don't get cleared up, rather they are all at "0" value once they are consumed and reset. This Jira is an enhancement to bring the idempotency in the class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)