[jira] [Commented] (RANGER-890) Fix "unnecessary" issues

["rangerqa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204649#comment-15204649 ] 

rangerqa commented on RANGER-890:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12794530/0001-RANGER-890-Fix-unnecessary-issues.patch
  against master revision 7e42940.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-RANGER-Build/117//testReport/
Console output: https://builds.apache.org/job/PreCommit-RANGER-Build/117//console

This message is automatically generated.

> Fix "unnecessary" issues
> ------------------------
>
>                 Key: RANGER-890
>                 URL: https://issues.apache.org/jira/browse/RANGER-890
>             Project: Ranger
>          Issue Type: Sub-task
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 0.6.0
>
>         Attachments: 0001-RANGER-890-Fix-unnecessary-issues.patch
>
>
> Fix the PMD "unnecessary" issues. I left the "UselessParentheses" out, as IMO there are too many changes required here.
> Review board URL: https://reviews.apache.org/r/45109/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)