[GitHub] [fineract] vorburger commented on a change in pull request #1368: Improve error handling if reporting service implementation is missing [FINERACT-1173]

[GitBox <gi...@apache.org>]

vorburger commented on a change in pull request #1368:
URL: https://github.com/apache/fineract/pull/1368#discussion_r528198275



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/RunreportsApiResource.java
##########
@@ -124,12 +125,13 @@ public Response runReport(@PathParam("reportName") @Parameter(description = "rep
             parameterTypeValue = "report";
             String reportType = this.readExtraDataAndReportingService.getReportType(reportName, isSelfServiceUserReport);
             ReportingProcessService reportingProcessService = this.reportingProcessServiceProvider.findReportingProcessService(reportType);
-            if (reportingProcessService != null) {
-                return reportingProcessService.processRequest(reportName, queryParams);
+            if (reportingProcessService == null) {
+                throw new PlatformServiceUnavailableException("err.msg.report.service.implementation.missing",
+                        ReportingProcessServiceProvider.SERVICE_MISSING + reportType, reportType);

Review comment:
       @ptuomola I'm finally (7 weeks later, phew!) picking this up, and I'm struggling to understand how the `reportType: SMS` is intended to work... @vidakovic do you understand that? Can those be run on the `/runreports` API? I think what I'll do is just write a `DefaultReportingProcessService` with the current code to which this will delegate to for both `Table` and `SMS`.. I'll therefore make the `type` on `org.apache.fineract.infrastructure.report.annotation.ReportService` a multivalue. Does that sounds reasonable to you guys?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org