You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/07/29 15:04:57 UTC

Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Fang Wang.


Bugs: CLOUDSTACK-1961


Repository: cloudstack-git


Description
-------

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


Diffs
-----

  services/console-proxy/server/js/ajaxviewer.js a6e1eda 

Diff: https://reviews.apache.org/r/13015/diff/


Testing
-------

Tested the fix on windows 7 guestOS and Xenserver hypervisor.


Thanks,

Sanjay Tripathi


Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24121
-----------------------------------------------------------


Cannot apply the patch because of whitespace errors. Can you fix it and give an updated patch.

- Devdeep Singh


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> -------
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24130
-----------------------------------------------------------


Review 13015 PASSED the build test
The url of build cloudstack-master-with-patch #68 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/68/

- Jenkins Cloudstack.org


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> -------
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24222
-----------------------------------------------------------


Commit e45888df961890af476f0f9f9b6d1c91c26cbbb6 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e45888d ]

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


- ASF Subversion and Git Services


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> -------
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24224
-----------------------------------------------------------


Commit 33122478c392a6471cf550c40d655b6f70e4701a in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3312247 ]

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


- ASF Subversion and Git Services


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> -------
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24225
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> -------
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>