You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by peihe <gi...@git.apache.org> on 2016/07/22 23:53:21 UTC

[GitHub] incubator-beam pull request #720: Remove overrides of isStreaming() and getA...

GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/720

    Remove overrides of isStreaming() and getAppName() in SparkPipelineOptions

    isStreaming() is already default to false implicitly, since it is not set.
    getAppName() defaults to the name of the class that constructs the PipelineOptions via the PipelineOptionsFactory.
    
    I think both should work in Spark. And, I see no reason to override them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam spark-app-name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #720
    
----
commit 7bbfef844caf31c14e3d0255d3073bec1d987476
Author: Pei He <pe...@google.com>
Date:   2016-07-22T23:49:34Z

    Remove overrides of isStreaming() and getAppName() in SparkPipelineOptions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #720: Remove overrides of isStreaming() and getA...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---