You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/06/14 12:57:47 UTC

[jira] [Commented] (CASSANDRA-2679) Move some column creation logic into Column factory functions

    [ https://issues.apache.org/jira/browse/CASSANDRA-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049118#comment-13049118 ] 

Sylvain Lebresne commented on CASSANDRA-2679:
---------------------------------------------

lgtm but can we rename the 'get' to 'create' (or 'make')  as this better suggest what those methods do.

> Move some column creation logic into Column factory functions
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-2679
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2679
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 0001-CASSANDRA-2679-Move-Deleted-Expiring-switch-and-contex.txt
>
>
> Expiring and Counter columns have extra creation logic that is better encapsulated when implemented inside a factory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira