You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "cetra3 (via GitHub)" <gi...@apache.org> on 2026/03/20 02:53:56 UTC
[PR] Fix Unparser for stacked Projections & Expand Unparser tests [datafusion]
cetra3 opened a new pull request, #21067:
URL: https://github.com/apache/datafusion/pull/21067
## Which issue does this PR close?
Fixes https://github.com/apache/datafusion/issues/21066
## Rationale for this change
The Unparser breaks in some certain scenarios, which also don't have test coverage.
## What changes are included in this PR?
- Fix: dequalify outer SELECT columns when wrapping stacked projections as derived subqueries
- Tests: parameterize unparser roundtrip tests over all dialects + optimized/unoptimized plans, add regression test suite
## Are these changes tested?
Yes, they are tested, the majority of this PR is to introduce *more* test paths.
## Are there any user-facing changes?
No breaking changes, but some SQL generated by the Unparser may end up being a little different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix Unparser for stacked Projections & Expand Unparser tests [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21067:
URL: https://github.com/apache/datafusion/pull/21067#issuecomment-4493926379
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix Unparser for stacked Projections & Expand Unparser tests [datafusion]
Posted by "cetra3 (via GitHub)" <gi...@apache.org>.
cetra3 commented on PR #21067:
URL: https://github.com/apache/datafusion/pull/21067#issuecomment-4494195146
I'm going to close this one off for now, this is a massive uphill battle to get working especially when optimizations are involved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix Unparser for stacked Projections & Expand Unparser tests [datafusion]
Posted by "cetra3 (via GitHub)" <gi...@apache.org>.
cetra3 commented on PR #21067:
URL: https://github.com/apache/datafusion/pull/21067#issuecomment-4095246739
OK adding the `optimized` pass and different dialects has actually opened a can of worms for parser corner & edge cases. I will see if I can work through these in this PR and if not, maybe will need to open a more conservative targeted PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix Unparser for stacked Projections & Expand Unparser tests [datafusion]
Posted by "cetra3 (via GitHub)" <gi...@apache.org>.
cetra3 closed pull request #21067: Fix Unparser for stacked Projections & Expand Unparser tests
URL: https://github.com/apache/datafusion/pull/21067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org